[IMP] openupgrade_160, openupgrade_tools: BS4 to BS5 transformation yeahhhhh #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # These replacements are from standard Bootstrap 4 to 5 | ||
| _BS5_REPLACEMENTS = ( | ||
| # Grid stuff |
There was a problem hiding this comment.
The comment i use here following the same order in https://getbootstrap.com/docs/5.1/migration
duong77476-viindoo
force-pushed
the
master_imp_boostrap4_to_5_transformation
branch
3 times, most recently
from
33f9e1e
to
aa7482f
Compare
|
Yeahhhhh! |
|
I have tested with PR OCA/OpenUpgrade#3949 , seem work fine, not sure i miss any thing or not :v |
duong77476-viindoo
force-pushed
the
master_imp_boostrap4_to_5_transformation
branch
3 times, most recently
from
af4e05a
to
3346708
Compare
| @@ -104,6 +104,7 @@ def convert_xml_node( | |||
| style_rm=frozenset(), | |||
| tag="", | |||
| wrap="", | |||
| attr_rp=None, | |||
There was a problem hiding this comment.
Here i added anaother option to allow attribute replacement, put it in the last to avoid error
Comment on lines
+262
to
+267
| def replace_html_replacement_attr_shortcut(attr_rp="", **kwargs): | ||
| """Shortcut to replace an attribute spec. | ||
|
|
||
| :param dict attr_rp: | ||
| EX: {'data-toggle': 'data-bs-toggle'} | ||
| Where the 'key' is the attribute will be replaced by the 'value' |
There was a problem hiding this comment.
Also define a shortcut for it
duong77476-viindoo
force-pushed
the
master_imp_boostrap4_to_5_transformation
branch
from
3346708
to
011d131
Compare
duong77476-viindoo
force-pushed
the
master_imp_boostrap4_to_5_transformation
branch
from
011d131
to
529ba55
Compare
duong77476-viindoo
force-pushed
the
master_imp_boostrap4_to_5_transformation
branch
3 times, most recently
from
734ec28
to
a1759d0
Compare
duong77476-viindoo
force-pushed
the
master_imp_boostrap4_to_5_transformation
branch
7 times, most recently
from
41799ce
to
5269546
Compare
text-justify removed
duong77476-viindoo
force-pushed
the
master_imp_boostrap4_to_5_transformation
branch
from
5269546
to
4fd0cb2
Compare
chienandalu
approved these changes
Aug 30, 2023
Thank you, although i think i might lack some cases, anyway it fine by me as i have already tested on a production database |
pedrobaeza
approved these changes
Oct 30, 2023
lijoantony
reviewed
Nov 11, 2023
| AsIs(field), | ||
| new_content, | ||
| id_, | ||
| ) |
There was a problem hiding this comment.
Is there a bug in the cr.execute() call, assuming syntax is cr.execute(query, params)?
I got the below error during migration which lead me here.
2023-11-11 15:54:29,149 58099 CRITICAL test odoo.service.server: Failed to initialize database `test`.
Traceback (most recent call last):
File "/Users/lijo/work/odoo16/odoo/service/server.py", line 1299, in preload_registries
registry = Registry.new(dbname, update_module=update_module)
File "<decorator-gen-16>", line 2, in new
File "/Users/lijo/work/odoo16/odoo/tools/func.py", line 87, in locked
return func(inst, *args, **kwargs)
File "/Users/lijo/work/odoo16/odoo/modules/registry.py", line 90, in new
odoo.modules.load_modules(registry, force_demo, status, update_module)
File "/Users/lijo/work/odoo16/odoo/modules/loading.py", line 523, in load_modules
migrations.migrate_module(package, 'end')
File "/Users/lijo/work/oca/OpenUpgrade/openupgrade_framework/odoo_patch/odoo/modules/migration.py", line 18, in migrate_module
MigrationManager.migrate_module._original_method(self, pkg, stage)
File "/Users/lijo/work/odoo16/odoo/modules/migration.py", line 189, in migrate_module
migrate(self.cr, installed_version)
File "/Users/lijo/miniforge3/envs/odoo16/lib/python3.8/site-packages/openupgradelib/openupgrade.py", line 2277, in wrapped_function
func(
File "/Users/lijo/work/oca/OpenUpgrade/openupgrade_scripts/scripts/website/16.0.1.0/end-migration.py", line 81, in migrate
convert_custom_qweb_templates_bootstrap_4to5(env)
File "/Users/lijo/work/oca/OpenUpgrade/openupgrade_scripts/scripts/website/16.0.1.0/end-migration.py", line 26, in convert_custom_qweb_templates_bootstrap_4to5
_convert_field_bootstrap_4to5_sql(env.cr, "ir_ui_view", "arch_db", ids=view_ids)
File "/Users/lijo/miniforge3/envs/odoo16/lib/python3.8/site-packages/openupgradelib/openupgrade_160.py", line 397, in _convert_field_bootstrap_4to5_sql
cr.execute(
TypeError: execute() takes from 2 to 4 positional arguments but 6 were given
Changing the execute call as below seems to fix it
cr.execute(
"UPDATE %s SET %s = %s WHERE id = %s",
(AsIs(table), AsIs(field), new_content, id_),
)
Is my understanding wrong?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BS4 to BS5 transformation yeahhhhh