Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][OU-ADD] website #3949

Merged
merged 1 commit into from
Oct 30, 2023
Merged

[16.0][OU-ADD] website #3949

merged 1 commit into from
Oct 30, 2023

Conversation

duyquyen96
Copy link
Contributor

No description provided.

@duyquyen96 duyquyen96 force-pushed the 16_add_website branch 2 times, most recently from 0c53f5d to da6e970 Compare June 30, 2023 04:51
@legalsylvain
Copy link
Contributor

legalsylvain commented Jun 30, 2023

/ocabot migration website

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 30, 2023
@duyquyen96 duyquyen96 force-pushed the 16_add_website branch 5 times, most recently from ace3dbb to 3372993 Compare July 1, 2023 09:46
@pedrobaeza
Copy link
Member

On this version, Odoo has upgraded Bootstrap from 4 to 5, so similar changes than in v12 would be needed:

@duong77476-viindoo duong77476-viindoo force-pushed the 16_add_website branch 2 times, most recently from f6bd7d4 to d24555d Compare July 11, 2023 07:51
@duong77476-viindoo
Copy link
Contributor

)


def keep_the_first_domain_when_duplicate(env):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why need this, do not understand ?

@duyquyen96
Copy link
Contributor Author

We are working on a separate repository, and once the code is completed, we will create a pull request to your repository.

@duyquyen96 duyquyen96 force-pushed the 16_add_website branch 5 times, most recently from c87d236 to 81ca47e Compare July 19, 2023 11:40
@chrisandrewmann
Copy link

Ran an upgrade from 15.0 with website. Generally ok but came across a strange issue when trying to edit header or footer on WYSIWYG editor afterwards. Not sure if it was OpenUpgrade or an Odoo bug so reported it as an issue on there.
odoo/odoo#132860

@duong77476-viindoo
Copy link
Contributor

@chrisandrewmann I suggest you regenerate asset after migrating, if not working then i'll try to reproduce it at my local

@chrisandrewmann
Copy link

chrisandrewmann commented Aug 29, 2023

Thanks @duong77476 for the quick reply. I've tried regenerating asset bundles a couple of times.
No joy.
If it helps also i'm using the Default website theme with "Slogan" header and the "Contact" footer option.

Update 30/09/23: I also tested an upgrade to v16 using the same DB but via the official Odoo upgrade platform, this issue does not appear so must be something OpenUpgrade specific regards website

@duong77476-viindoo
Copy link
Contributor

Thanks @duong77476 for the quick reply. I've tried regenerating asset bundles a couple of times. No joy. If it helps also i'm using the Default website theme with "Slogan" header and the "Contact" footer option.

oki thanks, i'll check it out later

@gdgellatly
Copy link

In testing a v13-v16 migration I received an error in the 15-16 step.

A prior xml id with the name Restricted Editor already existed with xml id website.group_website_publisher causing a duplicate key error

@PNurm
Copy link

PNurm commented Oct 25, 2023

Ran an upgrade from 15.0 with website. Generally ok but came across a strange issue when trying to edit header or footer on WYSIWYG editor afterwards. Not sure if it was OpenUpgrade or an Odoo bug so reported it as an issue on there. odoo/odoo#132860

This has happened to two different databases after migration to 14.0 > 15.0 >16.0. It seems to be caused by changes in 'website.layout' view. I've not yet pinpointed the exact change causing it as there are many, easier to just replace the arch completely with 16 version.

@duong77476-viindoo
Copy link
Contributor

Thank you everyone, i will resolve conflict today

@duong77476-viindoo
Copy link
Contributor

Done

@pedrobaeza
Copy link
Member

pedrobaeza commented Oct 30, 2023

I have pushed a rebased version improving a bit the documentation on the work file, and making a backup of the arch_db column before updating it, as OpenUpgrade should try to be as conservative as possible.

@chienandalu we will need later to add the same HTML fields conversion (BS4 > BS5 this time) that we have made in previous version, but there's still the problem with the malformed HTMLs.

@pedrobaeza pedrobaeza merged commit 6f13f41 into OCA:16.0 Oct 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants