Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] helpdesk mgmt timesheet #506

Closed
wants to merge 2 commits into from
Closed

[16.0][ADD] helpdesk mgmt timesheet #506

wants to merge 2 commits into from

Conversation

Zararthustra
Copy link

No description provided.

@Zararthustra Zararthustra marked this pull request as ready for review September 14, 2023 10:02
@vincent-hatakeyama
Copy link
Contributor

Port of #477 and improvement suggested in #425 (review)

@vincent-hatakeyama vincent-hatakeyama force-pushed the 16.0-add-helpdesk_mgmt_timesheet branch from bc5fe37 to fb99ddd Compare November 28, 2023 10:58
@vincent-hatakeyama vincent-hatakeyama force-pushed the 16.0-add-helpdesk_mgmt_timesheet branch from fb99ddd to 0b93389 Compare February 29, 2024 10:11
flotho
flotho approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy code review

pedrobaeza
pedrobaeza requested changes Apr 3, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not [ADD], but [IMP]. Please change commit messages.

@vincent-hatakeyama vincent-hatakeyama force-pushed the 16.0-add-helpdesk_mgmt_timesheet branch from 0b93389 to 75ea23f Compare April 5, 2024 15:06
@vincent-hatakeyama
Copy link
Contributor

This is not [ADD], but [IMP]. Please change commit messages.

I’ve just changed them.

flotho
flotho approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review
LGTM, thanks

@flotho
Copy link
Member

flotho commented May 29, 2024

could be closed because already available https://github.com/OCA/helpdesk/tree/16.0/helpdesk_mgmt_timesheet

@vincent-hatakeyama
Copy link
Contributor

could be closed because already available https://github.com/OCA/helpdesk/tree/16.0/helpdesk_mgmt_timesheet

That’s incorrect, the changes proposed in the PR have not been merged. I will open a new PR with me so I can edit have a correct title and edit the description.

@vincent-hatakeyama vincent-hatakeyama mentioned this pull request May 29, 2024
Merged
@vincent-hatakeyama vincent-hatakeyama deleted the 16.0-add-helpdesk_mgmt_timesheet branch June 5, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza requested changes

@flotho flotho flotho approved these changes

@OpenCode OpenCode OpenCode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Zararthustra @vincent-hatakeyama @flotho @OpenCode @pedrobaeza @marcelsavegnago @SergiCForgeFlow