Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] helpdesk_mgmt_timesheet: add optional ticket field in view and add avatar widget #582

Merged
merged 2 commits into from
Jun 5, 2024
Merged

[16.0][IMP] helpdesk_mgmt_timesheet: add optional ticket field in view and add avatar widget #582

merged 2 commits into from
Jun 5, 2024

Conversation

vincent-hatakeyama
Copy link
Contributor

Port of #477 and improvement suggested in #425 (review)

@vincent-hatakeyama vincent-hatakeyama changed the title [IMP] helpdesk_mgmt_timesheet: add optional ticket field in view and add avatar widget [16.0][IMP] helpdesk_mgmt_timesheet: add optional ticket field in view and add avatar widget May 29, 2024
@vincent-hatakeyama
Copy link
Contributor Author

Replaces #506

@marcelsavegnago marcelsavegnago added this to the 16.0 milestone May 29, 2024
@marcelsavegnago
Copy link
Member

@vincent-hatakeyama, I'm sorry about the confusion and for closing your PR. I didn't check the commits and mistakenly believed it was related to the module inclusion. Thank you for your contribution. #506

marcelsavegnago
marcelsavegnago approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flotho
Copy link
Member

flotho commented May 29, 2024

sadly impossible to test on ruboat :
image

even if it looks Ok :
image

Can't properly end the review,

Regards

@marcelsavegnago
Copy link
Member

sadly impossible to test on ruboat : image

even if it looks Ok : image

Can't properly end the review,

Regards

try again please

flotho
flotho approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionnal OK
Code review OK
LGTM
Thanks

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza
pedrobaeza approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-582-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit df4c4a9 into OCA:16.0 Jun 5, 2024
13 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f63cc38. Thanks a lot for contributing to OCA. ❤️

@vincent-hatakeyama vincent-hatakeyama deleted the 16.0-add-helpdesk_mgmt_timesheet branch June 5, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@flotho flotho flotho approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@vincent-hatakeyama @marcelsavegnago @flotho @OCA-git-bot @pedrobaeza @SergiCForgeFlow