Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0] FWD port of multiple PRs #814

Closed
wants to merge 70 commits into from
Closed

[15.0] FWD port of multiple PRs #814

wants to merge 70 commits into from

Conversation

etobella
Copy link
Member

@etobella etobella commented Sep 15, 2023

Small list of PRs pending to port to 15.0 😉

#639
#651
#652
#653
#645
#648
#662
#666
#672
#694
#696
#697
#698
#721
#762
#764
#763
#765
#767
#774
#778
#797
#790
#808

@OCA-git-bot
Copy link
Contributor

Hi @simahawk,
some modules you are maintaining are being modified, check this out!

@simahawk
Copy link
Contributor

@etobella we must add a blacklist file for oca-port. I'll add one for v16.
You can use the new cli command on oca-port to achieve this quickly with oca-port-pr blacklist OCA/edi#XX.
I have a pending TODO for v16 too 😉

Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR But it's green 🟢
We need to fix the tests on 15.0 branch.
So 🤞 on this one

@etobella
Copy link
Member Author

@simahawk shall we proceed with merge?

@pedrobaeza pedrobaeza added this to the 15.0 milestone Oct 2, 2023
@pedrobaeza
Copy link
Member

Wow, "small list of PRs" having 85 files changed. I wouldn't call it small...

Should I proceed with the merge?

@simahawk simahawk changed the title [15.0] Backport of multiple PRs [15.0] FWD port of multiple PRs Oct 2, 2023
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etobella IMO there are too many things here... included the migration of some modules, like 0f2904b

We cannot even bump properly the versions...

I don't think we need everything to fix the build.
I've just fixed the issue on v16 here OCA/edi-framework@f1e6976 and I will rework the fix for v14 and v15.

I'll check in a while

@simahawk
Copy link
Contributor

simahawk commented Oct 2, 2023

As for the builds... there you go:

v14 #822
v15 #823

@MiquelRForgeFlow
Copy link
Contributor

conflicts

You can now track the original exchange record
that originated the document in the 1st place.
Ease finding which type the current one is an ack for.
You can produce or receive more than one ack for a given exchange.
If that's the case, make sure only the newest is considered.
In case exchange_on is the same, use ID to get the latest on top.
Skip 'output_sent' records by default.
Reason: most of the times when a message is sent out
you don't care about its state anymore.
Any subsequent update from outside should come
with a new input record instead.

Yet, if for any reason this feature is required
you can still enable it by passing 'skip_sent=False'.
In this commit OCA@0a9b6d5
I unified the way these kind of methods were used.

Was breaking older implementations where the method was called directly.
simahawk and others added 26 commits October 25, 2023 15:55
Long awaited improvement.
Allows to decouple rules by model giving much more flexibility.
Migration steps included.
You can now customize and translate labels and tooltips for EDI automatic buttons.
Avoid warning because of duplicated Model field name while installing this module
Use `name()` because the real element could be namespaced on render
leading to mismatch by element type.
Custom kw args for rendering should be injected before snippets are evaluated.
This way they are available for the snippet
but also the snippet can override any custom param.
Use the full name of the partner by default to include parent name.
This behavior can be tweaked w/ the work context key 'party_data_name_field'.
@etobella etobella mentioned this pull request Nov 18, 2023
@simahawk simahawk closed this Nov 23, 2023
@etobella etobella deleted the 15.0-port branch November 27, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants