Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] edi_oca: Adapt tests to changes on error messages #819

Merged
merged 1 commit into from
Sep 27, 2023
Merged

[FIX] edi_oca: Adapt tests to changes on error messages #819

merged 1 commit into from
Sep 27, 2023

Conversation

etobella
Copy link
Member

@simahawk
Solves #818
I had to apply the same patch on #814

Might be related to odoo/odoo#135028 ?

@OCA-git-bot
Copy link
Contributor

Hi @simahawk,
some modules you are maintaining are being modified, check this out!

@etobella
Copy link
Member Author

@simahawk I tried to do this without removing the regex, but odoo is now using has_user_group, this checks if the call comes from a request and we are on debug mode. Obviously it is not the case on tests, so the result will never be accessible 😭

bosd
bosd approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review. Tests are passing again. :+1

@etobella
Copy link
Member Author

/ocabot merge patch

Merging as it is raising errors on current branch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-819-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 436f7ae into OCA:14.0 Sep 27, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c562f31. Thanks a lot for contributing to OCA. ❤️

@etobella etobella deleted the 14.0-tests branch September 27, 2023 10:37
@simahawk
Copy link
Contributor

simahawk commented Oct 2, 2023

has_user_group

you can still check the msg in the exception in theory. I'll have a look as I don't like we are not testing the right thing

@simahawk
Copy link
Contributor

simahawk commented Oct 2, 2023

FTR fixed like this on v16 OCA/edi-framework@f1e6976

@simahawk simahawk mentioned this pull request Oct 2, 2023
Merged
@QuocDuong1306 QuocDuong1306 mentioned this pull request Jan 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosd bosd bosd approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@etobella @OCA-git-bot @simahawk @bosd