Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][FW][IMP] base_edi: introduce a basic edi user group #1071

Merged
merged 1 commit into from
Dec 3, 2024
Merged

[17.0][FW][IMP] base_edi: introduce a basic edi user group #1071

merged 1 commit into from
Dec 3, 2024
+11 −0

Conversation

JordiMForgeFlow
Copy link
Contributor

FW of #1004

@OCA-git-bot
Copy link
Contributor

Hi @simahawk,
some modules you are maintaining are being modified, check this out!

@JordiMForgeFlow JordiMForgeFlow mentioned this pull request Nov 21, 2024
Closed
@SilvioC2C
Copy link

@JordiMForgeFlow PR LGTM but tests are failing

@JordiMForgeFlow
Copy link
Contributor Author

@victoralmau do you know why the test for test_base_import_pdf_by_template may be giving a wrong result?

@simahawk
Copy link
Contributor

simahawk commented Dec 2, 2024 •
edited
Loading

I'm trying to trigger the build on 17.0, let's see, but it could also be a flappy test.

@simahawk
Copy link
Contributor

simahawk commented Dec 2, 2024

well the build here is green #1056 :D

@JordiMForgeFlow
Copy link
Contributor Author

@simahawk they are modifying the module in that PR, so maybe those changes are needed in order to greenify this one.

@simahawk
Copy link
Contributor

simahawk commented Dec 3, 2024

MAybe #1080 :)

This was referenced Dec 3, 2024
Merged
Open
@victoralmau
Copy link
Member

Already solved with #1081

@JordiMForgeFlow
Copy link
Contributor Author

thank you @victoralmau :)

@simahawk
Copy link
Contributor

simahawk commented Dec 3, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-1071-by-simahawk-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ef5d721 into OCA:17.0 Dec 3, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 50465d4. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SilvioC2C SilvioC2C SilvioC2C approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JordiMForgeFlow @OCA-git-bot @SilvioC2C @simahawk @victoralmau