Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][FIX] test_base_import_pdf_by_template: Improve pattern #1082

Conversation

victoralmau
Copy link
Member

Backport from 17.0: #1081

Improve pattern

Related to #1071 (comment)

Related to pypdf 5.1.0 and line breaks

https://pypdf.readthedocs.io/en/latest/meta/CHANGELOG.html

@Tecnativa

@pedrobaeza pedrobaeza added this to the 15.0 milestone Dec 3, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as v17.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1082-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 3, 2024
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1082-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

Ouch, CI is red.

@victoralmau
Copy link
Member Author

The error is related to account_invoice_facturx but I don't know it and I don't know exactly how to solve it.

2024-12-03 13:15:12,935 368 ERROR odoo odoo.addons.account_invoice_facturx.tests.test_facturx_invoice: ERROR: TestFacturXInvoice.test_deep_customer_invoice
Traceback (most recent call last):
  File "/__w/edi/edi/account_invoice_facturx/models/account_move.py", line 873, in generate_facturx_xml
    xml_check_xsd(xml_byte, flavor="factur-x", level=ns["level"])
  File "/opt/odoo-venv/lib/python3.8/site-packages/facturx/facturx.py", line 172, in xml_check_xsd
    xsd_etree_obj = etree.parse(importlib.resources.files(__package__)
AttributeError: module 'importlib.resources' has no attribute 'files'

@pedrobaeza
Copy link
Member

This sounds as a library version update with incompatible changes.

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-1082-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 70bfd44 into OCA:15.0 Dec 4, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 12fd3c5. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-fix-test_base_import_pdf_by_template-tests branch December 4, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants