Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_reversal (reversal usability improvements) #1725

Open
wants to merge 77 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][MIG] account_reversal (reversal usability improvements) #1725

wants to merge 77 commits into from
+14,636 −0

Conversation

rousseldenis
Copy link

@rousseldenis rousseldenis commented Sep 19, 2023 •
edited
Loading

  • Adds reversal id field

@ and others added 30 commits September 18, 2023 14:40
@rousseldenis
[ADD] port account_reversal from v6.0 and add features : to_be_revers…
51293b4 
…ed flag and reversal_id many2one

(lp:c2c-addons/6.1  rev 5609)
@guewen @rousseldenis
[MIGR] set installable to False on all the modules, the flag has to b…
2f376a1 
…e reactivated when the modules are migrated
@guewen @rousseldenis
[MIGR] set account_reversal installable
3f9a571
@guewen @rousseldenis
[IMP] manifest
f3b8a6c
@guewen @rousseldenis
[FIX] encoding should be coding
dc01b23
@guewen @rousseldenis
[FIX] license mess, the whole addon is release under AGPLv3 but a pyt…
03117fa 
…hon module contains GPLv2
@guewen @rousseldenis
[IMP] python formatting, OpenERP standards
c9cff7a
@guewen @rousseldenis
[FIX] remove useless type in views
bdcac9b
@guewen @rousseldenis
[FIX] one more type to remove
534b5a9
@guewen @rousseldenis
[IMP] views for version 7.0
c649a4a
@yvaucher @rousseldenis
[IMP] python formating
c6cfeeb
@rousseldenis
[IMP] Translation template files for all modules.
23f81b4
@rousseldenis
Launchpad automatic translations update.
1b46f69
@rousseldenis
[FIX] Avoid a crash when the next period doesn't exist (for example :…
a7c9dfe 
… you are in December 2013 and FY 2014 is not created yet).

Add prefer_normal_period in period selection.
@rousseldenis
Launchpad automatic translations update.
51307c1
@nbessi @rousseldenis
Set all addons to uninstallable
645214c
@nbessi @rousseldenis
Rename all addons to xxx_unported to be travis compliant
e903be6
@rousseldenis
Revert "Rename all addons to xxx_unported to be travis compliant"
f7700db 
This reverts commit 7eb1827.
@rousseldenis
[FIX] move all unported addons into __unported__ folder instead of ad…
9131053 
…ding _unported suffix
@nbessi @rousseldenis
[FIX] flake8 PEP8 for module account_reversal
6c83728
@guewen @rousseldenis
Move account_reversal from __unported__ to root folder
abaded3
@guewen @rousseldenis
Move the description in README.rst
1557a2c
@guewen @rousseldenis
Set the module installable
98d3e4f
@guewen @rousseldenis
Use relative imports
5c19c6c
@guewen @rousseldenis
Size useless on char fields
261aa1f
@sbidoul @rousseldenis
[FIX] pylint relative imports
7e2fc13
@sbidoul @rousseldenis
[IMP] improve account_reversal fr translation
345c739
@rschnapka @rousseldenis
initial german translation (mostly)
622be60
@rschnapka @rousseldenis
removed extra linefeed
951b86c
@gurneyalex @rousseldenis
Add OCA as author of OCA addons
9e02bdc 
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
oca-transbot and others added 10 commits September 19, 2023 11:24
@oca-transbot @rousseldenis
OCA Transbot updated translations from Transifex
d09af4a
@rousseldenis
[FIX] account_reversal - Reverse multiple journal entries.
4a03d94
@rousseldenis
[FIX] account reversal typo
f218614
@oca-travis @rousseldenis
[UPD] Update account_reversal.pot
0db30b1
@rousseldenis
Translated using Weblate (Dutch)
3b3060d 
Currently translated at 100.0% (30 of 30 strings)

Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_reversal
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_reversal/nl/
@oca-transbot @rousseldenis
Update translation files
4cd33a4 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@rousseldenis
[11.0][IMP] Journal Entries to be Reversed menu
c8fac8c
@oca-transbot @rousseldenis
Update translation files
832df58 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_reversal
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_reversal/
@rousseldenis
[IMP] account_reversal: pre-commit stuff
90e12c8
@rousseldenis
[16.0][MIG] account_reversal
403c1a3 
Migration to 16.0 by expanding core features adding:

- The line reason to reversal
- The 'To Be Reversed' field and filter
- Displaying the move reason not only for invoices
@sbejaoui sbejaoui mentioned this pull request Nov 6, 2023
Draft
@IT-Ideas IT-Ideas mentioned this pull request Nov 7, 2023
Closed
[IMP] account_reversal: add reversal_id field
668e9a4 
This commit adds the `reversal_id` field in order to improve
the UX of the move reversal functionality. The field has been
added to the form view close to the `reversed_entry_id` field
already present in the view.

This commit also introduces a constraint preventing the user
to flag a move as to be reversed when a non cancelled reversal
move has already been created. This allows simplifying the domain
used on the `to_be_reversed` filter.

Finally, it also convert the deprecated `SavepointCase` test
into a `TransactionCase` one.

Fixes: OCA#1761
@IT-Ideas
Copy link

Hello @rousseldenis, I just added a commit in order to fix #1761. Could you add it in the PR message?

@sbidoul sbidoul added this to the 16.0 milestone Jan 1, 2024
@sbidoul sbidoul changed the title [16.0][MIG] account_reversal [16.0][MIG] account_reversal (reversal usability improvements) May 21, 2024
@sbidoul
[IMP] account_reversal: improve fields ordering in view
1915f27 
After this commit, the order is
- To be reversed flag
- Reversal Entry
- Reversal of

Before, the flag was between the entries which was weird.
@sbidoul
[FIX] account_reversal: handle lines with empty label
89f1663
@sbidoul
[IMP] account_reversal: clarify help and documentation
cfc1ec0
@sbidoul
Copy link
Member

sbidoul commented May 21, 2024

I have pushed a couple of minor fixes and clarifications.

I think it's ok to keep the module name as is to reduce migration burden for users of the module in older Odoo versions.

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 22, 2024
@github-actions github-actions bot closed this Oct 27, 2024
@sbidoul sbidoul reopened this Oct 27, 2024
@sbidoul sbidoul removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IT-Ideas IT-Ideas IT-Ideas left review comments

@sbejaoui sbejaoui sbejaoui approved these changes

@sbidoul sbidoul sbidoul approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.