Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_invoice_accrual #264

Draft
wants to merge 84 commits into
base: 16.0
Choose a base branch
from
Draft

[16.0][MIG] account_invoice_accrual #264

wants to merge 84 commits into from

Conversation

sbejaoui
Copy link
Contributor

No description provided.

@sbejaoui sbejaoui force-pushed the 16.0-account_invoice_accrual-sbj branch 2 times, most recently from 02999b3 to 4271026 Compare September 21, 2023 08:05
@sbejaoui sbejaoui changed the title [WIP][16.0][MIG] account_invoice_accrual [16.0][MIG] account_invoice_accrual Sep 21, 2023
@sbejaoui
Copy link
Contributor Author

cc/ @jbaudoux , @rousseldenis

sbejaoui
sbejaoui commented Nov 6, 2023
View reviewed changes
account_invoice_accrual/models/account_move.py
copy=False,
help="Link to the Accrual Journal Items.",
)
to_be_reversed = fields.Boolean("To be reversed")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME: depend on OCA/account-financial-tools#1725

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 17, 2024
@jbaudoux
Copy link
Contributor

Replaced by #271

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 24, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 28, 2024
@jbaudoux
Copy link
Contributor

This PR can be closed as replaced by #271

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 4, 2024
@sbidoul
Copy link
Member

sbidoul commented Oct 30, 2024

This PR can be closed as replaced by #271

I have situations where the draft invoice has been emitted or invoice posted in the next period but before the closing of the previous period is done, so in that case, a helper to do the accrual is useful.

sbidoul
sbidoul reviewed Oct 30, 2024
View reviewed changes
account_invoice_accrual/models/res_company.py Outdated
)
dft_accrual_expense_journal_id = fields.Many2one(
comodel_name="account.journal", string="Default Journal for Accrued Expenses"
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part should go to account_cutoff_base, I think.

Laetitia Gangloff and others added 14 commits October 30, 2024 16:26
@sbidoul
Add account_invoice_accrual module
aec0bab
@adrienpeiffer @sbidoul
Crash without model=model_name
3db1085
@adrienpeiffer @sbidoul
view_load attribute is deprecated on ir.fields
e958759
@adrienpeiffer @sbidoul
Some fixes to make yml tests happy
da819ec
@adrienpeiffer @sbidoul
Flake8 and pylint issues
43097a6
@adrienpeiffer @sbidoul
Bad display for account_accrual_move_id
24b9468
@adrienpeiffer @sbidoul
Avoid to copy accural_move_id
cc753cf
@adrienpeiffer @sbidoul
Type isn't initialized
5396a18
@adrienpeiffer @sbidoul
Use accrual date to set date on analytic line not invoice date that c…
b4f6dac 
…an be not initialized
@adrienpeiffer @sbidoul
Add README
e294eed
@adrienpeiffer @sbidoul
Account_invoice_accrual refactoring : * Remove accrual information on…
01c12f1 
… res_partner * Use default cutoff journal which is on company * Use accrual accounts defined on account_cutoff_accraul_base * Use accounts mapping which is implemented in account_cutoff_base * Adapt test suite
@adrienpeiffer @sbidoul
Remove/reversal accrual : * Remove accrual in case of cancel or unlin…
0000581 
…k invoice if accrual entry is draft * Remove accrual in case of invoice's validation if accrual entry is draft and if entry genereted by the validation is on the same period as accrual * Otherwise, accrual entry is reversed
@adrienpeiffer @sbidoul
Add the possibility to consider taxes on accrual or not
6168685
@adrienpeiffer @sbidoul
set to_be_reversal to true after accrual
4c95ab5
adrienpeiffer and others added 19 commits October 30, 2024 16:26
@adrienpeiffer @sbidoul
[FIX] account_invoice_accural: generation from foreign currency invoice
bc3127c
@jbaudoux @sbidoul
[FIX] fix after rebase; moved accrual_taxes to base accrual module; f…
0bf7a85 
…ixed journal and number for accrual move and reversal
@jbaudoux @sbidoul
[FIX] set active_id(s) in context already for reverse wizard creation…
712acbf 
… to solve journal issue
@jbaudoux @sbidoul
Extend invoice accrual with support of invoice merge
7090948
@jbaudoux @sbidoul
Use return account for refund invoices
8d09c63
@jbaudoux @sbidoul
Fix singleton error when making accrual on multiple invoices
510703b
@sbidoul
add contributor
8834df9
@oca-travis @sbidoul
[UPD] Update account_invoice_accrual.pot
6767e3f
@rschnapka @sbidoul
Translated using Weblate (German)
9087ef3 
Currently translated at 100,0% (39 of 39 strings)

Translation: account-closing-10.0/account-closing-10.0-account_invoice_accrual
Translate-URL: https://translation.odoo-community.org/projects/account-closing-10-0/account-closing-10-0-account_invoice_accrual/de/
@jbaudoux @sbidoul
Fix typo self.env.context
c83d39d
@OCA-git-bot @sbidoul
[UPD] README.rst
152c2b2
@sbidoul
[FIX] account_invoice_acccrual: pep8
723b6d7
@oca-travis @sbidoul
[UPD] Update account_invoice_accrual.pot
d0466b3
@OCA-git-bot @sbidoul
[UPD] README.rst
24ddf4d
@oca-transbot @sbidoul
Update translation files
1eeef96 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@OCA-git-bot @sbidoul
[ADD] icon.png
cc86050
@sbejaoui @sbidoul
[12.0][MIG] - account_invoice_accrual migration to 12.0
78276a3
@sbejaoui @sbidoul
Fix po file
1a87a7f
@sbejaoui @sbidoul
[FIX] - Fix reversal action id
afd350b
@sbidoul sbidoul force-pushed the 16.0-account_invoice_accrual-sbj branch 2 times, most recently from ad43d36 to 874d4b9 Compare October 30, 2024 15:29
@sbidoul sbidoul force-pushed the 16.0-account_invoice_accrual-sbj branch from 874d4b9 to fc9e21c Compare October 30, 2024 15:31
@sbidoul sbidoul force-pushed the 16.0-account_invoice_accrual-sbj branch from fc9e21c to 80ac7e3 Compare October 30, 2024 15:33
@sbidoul sbidoul marked this pull request as draft October 30, 2024 16:16
@sbidoul
Copy link
Member

sbidoul commented Oct 30, 2024

Resetting to draft as this is not ready

@sbidoul
Copy link
Member

sbidoul commented Oct 31, 2024

To me the logic to compute the accrual move lines in this PR is unclear, and, I think incorrect.

It should rather take invoice.invoice_line_ids and and accrue these lines after mapping the account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaudoux jbaudoux jbaudoux left review comments

@sbidoul sbidoul sbidoul left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sbejaoui @jbaudoux @sbidoul @adrienpeiffer @oca-transbot @benwillig @oca-travis @rschnapka @OCA-git-bot