Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_cutoff_base: Allow to configure different account for refunds (credit notes) #283

Merged
merged 1 commit into from
Oct 30, 2024
Merged

[16.0][MIG] account_cutoff_base: Allow to configure different account for refunds (credit notes) #283

merged 1 commit into from
Oct 30, 2024

Conversation

jbaudoux
Copy link
Contributor

Forward port commit 83e9b1c

@OCA-git-bot
Copy link
Contributor

Hi @alexis-via,
some modules you are maintaining are being modified, check this out!

@jbaudoux jbaudoux mentioned this pull request Nov 17, 2023
Draft
@jbaudoux
[IMP] account_cutoff_base
4ecf536 
Allow to configure different account for refunds (credit notes)
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 23, 2024
@github-actions github-actions bot closed this Jul 28, 2024
@jbaudoux
Copy link
Contributor Author

@OCA/accounting-maintainers Could you reopen this PR and merge it ?

cc @rousseldenis

@grindtildeath grindtildeath reopened this Jul 29, 2024
@OCA-git-bot
Copy link
Contributor

Hi @alexis-via,
some modules you are maintaining are being modified, check this out!

@grindtildeath grindtildeath added needs review no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Jul 29, 2024
@jbaudoux jbaudoux changed the title [16.0][MIG] Allow to configure different account for refunds (credit notes) [16.0][MIG] account_cutoff_base: Allow to configure different account for refunds (credit notes) Aug 26, 2024
@jbaudoux
Copy link
Contributor Author

@adrienpeiffer Can you merge this one also ?
cc @lmignon

adrienpeiffer
adrienpeiffer reviewed Oct 18, 2024
View reviewed changes
account_cutoff_base/models/res_company.py
string="Default Account for Accrued Revenues Refunds",
check_company=True,
)
default_accrued_expense_return_account_id = fields.Many2one(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbaudoux Where these fields are used ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are used in other, not yet merged modules.

@sbidoul
Copy link
Member

sbidoul commented Oct 30, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-283-by-sbidoul-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d4a8fb5 into OCA:16.0 Oct 30, 2024
12 of 13 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 23a1eb3. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrienpeiffer adrienpeiffer adrienpeiffer left review comments

@sbidoul sbidoul sbidoul approved these changes

Assignees
No one assigned
Labels
merged 🎉 needs review no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbaudoux @OCA-git-bot @sbidoul @adrienpeiffer @grindtildeath