[ADD] 14.0 account_move_cutoff: deferred revenu/expenses #256
Conversation
petrus-v
force-pushed
the
14.0-add-account-move-cutoff
branch
5 times, most recently
from
914878e
to
3a223a1
Compare
|
Last empty commit is a workaround github issue: https://github.com/orgs/community/discussions/62366 I'll squash it... |
petrus-v
force-pushed
the
14.0-add-account-move-cutoff
branch
from
7a00d88
to
3d6634d
Compare
| line_amounts = {} | ||
| if self.cutoff_method == "equal": | ||
| line_amounts = self._get_amounts_per_periods_equal() | ||
| else: # monthly_prorata_temporis |
There was a problem hiding this comment.
elif with exception if cutoff_method is not recognized ? this seems dangerous otherwise
There was a problem hiding this comment.
cutoff_method is a field selection with 2 value today, ORM ensure possible value before to be able to call this code I think. So it will be hard to test exception case 🤔
|
This PR has the |
petrus-v
force-pushed
the
14.0-add-account-move-cutoff
branch
from
4c581f6
to
8d9ad8c
Compare
|
@pedrobaeza @fclementic2c any chance this one gets reviewed? |
|
Merging due to existing reviews, but not reviewed by me: /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-256-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
pre-commit should be fixed for this branch, as an update of the checkers make that some existing modules are not passing. |
|
thanks a lot. We will update this PR and ping you when it's all green again. |
Using this module cuttoff happens while posting entries based on start/end date defined on invoice lines Co-authored-by: Damien Crier <[email protected]>
petrus-v
force-pushed
the
14.0-add-account-move-cutoff
branch
from
8d9ad8c
to
dfe7334
Compare
|
@damdam-s @pedrobaeza thanks ! I've rebase this branch and fix linters complaints |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 3f320d7. Thanks a lot for contributing to OCA. ❤️ |
Using this module cuttrof happens while posting
entries based on start/end date
This module intentionally not depends on
account_cutoff_base