-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][OU-ADD] account: Migration to 17.0 #4662
Conversation
e95fe40
to
38c4505
Compare
/ocabot migration account |
@hbrunn do you want to work on the rest? |
openupgrade.logged_query( | ||
env.cr, | ||
f"""UPDATE account_tax | ||
SET description = {'en_US': {openupgrade.get_legacy_name('description')}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not working yet.
@pedrobaeza can you make this PR writable for maintainers? |
I'm afraid it's something of GitHub itself, as it has been pushed from a organization branch. Feel free to open a new one if you finish it. There's now a CI problem whose roots have been investigated here: Tecnativa/doodba#636 |
I won't be able to add anything today, will have a look if there's anything left over next Monday |
PS: Let's then to PRs from our personal forks to facilitate collaboration in the future |
OK, I will continue with this PR during the week.
Yeah, it was the habit, as in our team we always push everything to Tecnativa to promote that collaboration (as others don't have repo maintainer role). |
We can also make a PR on OpenUpgrade repo. (OpenUpgrade:17.0-account) So all the maintainers can push on it. |
good idea about pushing to /oca, will do. Continuing this now |
superseded by #4668 |
Continuation of #4457
@Tecnativa TT49274