[17.0][OU-ADD] account: migration to 17.0 #4457
Conversation
|
/ocabot migration account Depends on : |
duong77476-viindoo
force-pushed
the
v17_ou_add_account
branch
from
5e571f7
to
0ea0a9e
Compare
duong77476-viindoo
force-pushed
the
v17_ou_add_account
branch
from
0ea0a9e
to
0c5a077
Compare
duong77476-viindoo
force-pushed
the
v17_ou_add_account
branch
from
0c5a077
to
f187d19
Compare
|
@flachica Hello, i apply your fix here, please notify me if you have something in your mind :v |
I will close my PR and internally use this branch. Thanks for you amazing work. |
|
Hello, I'm creating a new analysis tool called odoo-module-diff, it's explained here: https://github.com/akretion/odoo-module-diff To review or complete the PR, you might be interested by these key commits of the account module migration to 17.0: |
| ] | ||
|
|
||
| _columns_copies = { | ||
| "account_tax": [("description", "invoice_label", "JSONB")], |
There was a problem hiding this comment.
When trying the script, I get the following error:
psycopg2.errors.DatatypeMismatch: column "invoice_label" is of type jsonb but expression is of type character varying
LINE 4: ... UPDATE account_tax SET invoice_label=description
| convert_column_translatable(env.cr, "account_tax", "description", "jsonb") | ||
| openupgrade.copy_columns(env.cr, _columns_copies) |
There was a problem hiding this comment.
@ecino Ok maybe do same here
| ) | ||
|
|
||
|
|
||
| def _res_partner_bank_create_column(env): |
|
|
||
| account / res.partner.bank / has_iban_warning (boolean) : NEW isfunction: function, stored | ||
| account / res.partner.bank / has_money_transfer_warning (boolean): NEW isfunction: function, stored | ||
| # DONE create column in pre-migration and compute using orm in end-migration |
| @@ -0,0 +1,13 @@ | |||
| # Copyright 2024 Viindoo Technology Joint Stock Company (Viindoo) | |||
| ---XML records in module 'account'--- | ||
| DEL account.payment.term: account.account_payment_term_2months (noupdate) | ||
| DEL account.tax.group: account.tax_group_taxes (noupdate) | ||
| # DONE: removed in post-migration |
There was a problem hiding this comment.
as written above, I think we should keep them
| DEL ir.model.constraint: account.constraint_account_report_line_code_uniq | ||
| DEL ir.model.constraint: account.constraint_account_tax_name_company_uniq | ||
| DEL ir.model.constraint: account.constraint_account_tax_template_name_company_uniq | ||
| DEL ir.model.constraint: account_sequence.constraint_account_move_unique_name |
There was a problem hiding this comment.
this one is actually added in account now, so we need to uniquify names.
And the whole _work file needs updating from the current analysis file, it contains confusing bogus entries
|
I'll create a followup-PR next Monday of nobody else has picked this up until then |
Thank you sir |
|
I didn't manage to finish this today, so I just pushed an intermediate version on my fork. |
|
@hbrunn is this finished on your side (or on hold)? It's for resuming from here. |
|
my comments from #4457 (comment) down need addressing still, so if you've the time, please resume from there |
|
PS: I'll continue with this on Monday if I don't hear anything to the contrary |
|
I'm today resuming this, so probably it will be done. I'll tell you. |
|
I don't find any new commits on https://github.com/Tecnativa/OpenUpgrade/commits/17.0-account - what are you working on so that I can do something else today? |
|
I'm still working on this. |
|
today? |
|
Yes, I will push my result at the end of the morning. |
|
great, then I'll pick it up from there and do some more reviews meanwhile |
|
? |
|
I have opened #4662, but it's still not finished. I'm just stuck at the new |
No description provided.