-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONTRIBUTING.md: Schema development process, improved mermaid diagram, etc. #4186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clear and concise. Well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, minor nits
@ralfhandl I have made some changes and updated. Changes include:
|
@handrews Why do we need the If we would branch What would we loose with this simplification? |
We needed the |
That is my impression: the |
From later comments on the previous update. This shows a more comprehensive example, including merging patch releases from the most recent line _only_ back to `dev`.
And also add some section headers and clarify publishing a bit.
Co-authored-by: Ralf Handl <[email protected]>
@ralfhandl we have had this discussion before. I just added a section explaining further. I don't like just stacking (BTW, we could dispense with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @handrews!
More work towards #3715 and #3716.
Also paging @jeremyfiel as GitHub won't let me add you as a reviewer.