Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.1-dev: schema tests use src/schemas/validation #4197

Closed
wants to merge 1 commit into from

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Nov 13, 2024

Run schema tests with current work-in-progress schema in src/schemas/validation folder

Open:

  • Should the pass and fail folders with schema test instances also be copied into the src/schemas/validation folder?

@ralfhandl ralfhandl requested review from a team as code owners November 13, 2024 08:33
@ralfhandl ralfhandl added this to the v3.1.2 milestone Nov 13, 2024
@ralfhandl ralfhandl changed the base branch from main to v3.1-dev November 13, 2024 09:07
@handrews
Copy link
Member

@ralfhandl I'm now realizing that actually (per the update to CONTRIBUTING.md that I just made in #4186) that this (and, sadly, #4196 which I merged before thinking about it) should start on dev and then be merged out to the vX.Y-dev branches from there.

dev should be where everything fully works, so that each time we start a new vX.Y-dev branch from dev, it always gets the most up-to-date infrastructure. We never want to have to think about which branch is active or most current or whatever when starting new branches in the future. We just want to keep dev in good shape as the place where new branches always start.

@ralfhandl ralfhandl changed the base branch from v3.1-dev to dev November 13, 2024 18:42
@ralfhandl ralfhandl changed the base branch from dev to v3.1-dev November 13, 2024 18:42
@ralfhandl
Copy link
Contributor Author

@ralfhandl
Copy link
Contributor Author

I cherry-picked the only commit in this PR for #4198.

Do we want to merge this PR, or open a new one updating v3.1-dev from dev?

@lornajane
Copy link
Contributor

As discussed in TDC call, closing in favour of #4198

@ralfhandl ralfhandl closed this Nov 14, 2024
@ralfhandl ralfhandl deleted the v3.1-schema-tests branch November 14, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants