Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop stable low pass filter algorithms for voltages and temperatures #173

Open
dyldonahue opened this issue Sep 3, 2024 · 3 comments · May be fixed by #210
Open

Develop stable low pass filter algorithms for voltages and temperatures #173

dyldonahue opened this issue Sep 3, 2024 · 3 comments · May be fixed by #210
Assignees
@DimitryP6
Labels
enhancement New feature or request

Comments

@dyldonahue
Copy link
Contributor

Current Features

We have used various instable, volatile, and aggressive algorithms to eliminate noise form our data readings. These are case-specific to behavior weve seen, not strong agaisnt edge cases, and generally over aggresive

Desired Additional Features

We should create stable low pass filtering to eliminate high frequency noise. This should be a simple and generalized filter that can be applied to data of any kind. It should not be especially aggressive and should just work as a no brainer to apply to any incoming data

Screenshots (as needed)

No response
@dyldonahue dyldonahue added the enhancement New feature or request label Sep 3, 2024
@Sabramz Sabramz self-assigned this Sep 11, 2024
@Sabramz Sabramz removed their assignment Sep 21, 2024
@jr1221 jr1221 transferred this issue from Northeastern-Electric-Racing/Shepherd-BMS Oct 10, 2024
@jr1221
Copy link
Contributor

jr1221 commented Oct 10, 2024

Check out cerberus/dti.c for examples of low pass filters.

@jr1221
Copy link
Contributor

jr1221 commented Oct 10, 2024

https://github.com/Northeastern-Electric-Racing/Cerberus/blob/39d056a668c43d7f23e70a3f341a94cb17d78e98/Core/Src/dti.c#L46

@jr1221
Copy link
Contributor

jr1221 commented Oct 10, 2024

https://beej.us/guide/bgc/html/split/

@dyldonahue dyldonahue mentioned this issue Oct 11, 2024
Open
DimitryP6 added a commit that referenced this issue Nov 17, 2024
@DimitryP6
#173: casual lowpass filter
2f4449d
DimitryP6 added a commit that referenced this issue Nov 17, 2024
@DimitryP6
#173: fixed clang format issue
be7ef9a
DimitryP6 added a commit that referenced this issue Nov 19, 2024
@DimitryP6
#173: moxed to middleware folder and removed examples
6a2eeaa
DimitryP6 added a commit that referenced this issue Nov 19, 2024
@DimitryP6
#173: finalized file location
5e4840d
@DimitryP6 DimitryP6 mentioned this issue Nov 20, 2024
Closed
@DimitryP6 DimitryP6 linked a pull request Nov 20, 2024 that will close this issue
Lowpass filter #202
Closed
DimitryP6 added a commit that referenced this issue Dec 2, 2024
@DimitryP6
#173: Added a simple_ema.h file
6811331
@DimitryP6 DimitryP6 linked a pull request Dec 2, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimitryP6 DimitryP6

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
4 participants
@jr1221 @Sabramz @dyldonahue @DimitryP6