Feature/lowpass filter #210
Open
+24
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jr1221
requested changes
Dec 4, 2024
| #define SIMPLE_EMA | ||
|
|
||
| // Exponential Moving Average Lowpass Filter | ||
| ema_filter(float current_value, float *previous_ema, float alpha); |
There was a problem hiding this comment.
needs void no?
A good way to ensure your code builds is to run it in Cerberus.
Steps to do so:
- Commit to ur branch in embedded base
- Clone
Cerberus - Enter the ./Drivers/Embedded-Base directory in Cerberus and run
git fetchandgit checkout <your-branch-name> - Now update cerberus
Makefilewith the relevant .c file you want to test - run
ner buildand observe any errors/warnings
Lmk if you have questions about these steps, if you need instructions to setup ner build check here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added the simple_ema.h file and renamed branch
Notes
Alpha works well for 0.1
Test Cases
To Do
Any remaining things that need to get done
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
Closes #173