-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added JSON file with GAP appearance values from BT SiG #107
Added JSON file with GAP appearance values from BT SiG #107
Conversation
@eriklins Thanks! I'll have a look tomorrow if that's okay. |
@eriklins All okay. You just need to accept the CLA |
Hi Dinesh, strange thing is, that I did accept the CLA already, see screenshot. No clues why it shows still pending with the PR. I selected "recheck", but not change. Not sure how to re-accept it, when clicking on the accept link, it won't let me do any changes but just says, that I already accepted. |
Hello, |
So, I did not use an email address for the commit (did this with Tortoise Git on my PC and seems I had not configured that properly, fixed it now) but just the username. How would I get this matched to the email address on github (where I did the PR), since there actually is no email address in the commit? |
So you can ammend your commit with your correct username and then git push -f to the branch with this PR |
amend commit sh: line 1: q: command not found
Thanks for the help Dinesh and Aleksander, seems it did work now. |
@eriklins thanks to you. Sorry about the delay regarding looking into this, because I had a swamp of other work things |
As discussed with @dinesharjani in #106 here is my pull-request with gap_appearance.json file. This file has been automatically created from BT SiG bitbucket url @https://bitbucket.org/bluetooth-SIG/public/src/main/assigned_numbers/core/appearance_values.yaml with an own Python script. I did not modify any of the existing JS scripts since I couldn't fully figure which do what. I'm happy to update the appearance values on a regular basis, if need be.