Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GAP Appearance Values #106

Closed
eriklins opened this issue Dec 20, 2023 · 4 comments
Closed

Add GAP Appearance Values #106

eriklins opened this issue Dec 20, 2023 · 4 comments

Comments

@eriklins
Copy link
Contributor

Any plans for adding another JSON with the GAP Appearance Values (BT SiG Assigned Numbers document section 2.6)...?

Would you accept a pull-request if I would add a JSON file with these?

@dinesharjani
Copy link
Collaborator

@eriklins we don't have "plans" at the moment, since I'm juggling many things. And we have big incoming hardware this year (Apple Vision Pro), Mac release of nRF Connect, etc.

If you want to do a pull request, I'd by all means accept it. Just keep in mind this would need to be a /v2, to not break existing users of /v1 if you change the format too much, and that the scripts would also need to be updated.

@eriklins
Copy link
Contributor Author

eriklins commented Dec 27, 2023

Thanks for following up. I would not change any of the existing JSON files but would rather add an additional one containing the GAP appearance values. This should hence not conflict with anyone using just the existing JSON files, so a /v2 might not be necessary. Thoughts?

@dinesharjani
Copy link
Collaborator

I'd love to see it. My only concern is that the data type is clear, in the sense that, for example, there are multiple types of "temperature" data, or ways of storing a float, etc. That was my initial reason for not getting into this mess. But sure, I'd love to see your PR. If it includes patches for the scripts where necessary (or if necessary) and the types look extensible for other Data as well as not confusing to see / understand from the perspective of someone using this library, I think this could be a win for everyone.

@eriklins
Copy link
Contributor Author

eriklins commented Jan 10, 2024

Solved with #107 and issue can be closed. Thanks all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants