Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests timezone updates. DOM type in suites title. #195

Merged
merged 4 commits into from
Aug 14, 2018
Merged

Tests timezone updates. DOM type in suites title. #195

merged 4 commits into from
Aug 14, 2018

Conversation

programmer4web
Copy link
Contributor

@programmer4web programmer4web commented Jul 2, 2018 •
edited
Loading

#187

  1. Date, datetime timezone update. Done.
  2. Time tests need timezone update. Done.
  3. Verify with different time zones that tests are passing. Done.
  4. Show shady / shadow in suite title. Done.

nomego
nomego approved these changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@nomego nomego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Substringing datestrings and injecting timezone-based hours and days into date/datetime strings are normally recipes for disaster.. but I guess we can adjust the tests later if we ever hit issues.

@nomego nomego requested review from megheaiulian and plequang July 2, 2018 09:05
@programmer4web
Copy link
Contributor Author

@nomego I will try to find an better way to test.

@programmer4web programmer4web force-pushed the feature/NEOV-237-tests-timezone branch from b3261a1 to 35d7dc4 Compare July 3, 2018 13:37
@programmer4web programmer4web changed the title [WIP] tests timezone update Tests timezone updates. DOM type in suites title. Jul 4, 2018
@programmer4web programmer4web force-pushed the feature/NEOV-237-tests-timezone branch from d333070 to f14e0ce Compare July 23, 2018 08:40
@programmer4web @megheaiulian
test _toLocalISOString updated
a90b133 
fixed timezone difference.
filtering on specific date - updated

timezone fix
filtering from day 22 to 23 - updated

timezone fix.
old tests in milliseconds removed 


datetime _toHashString updated

timezone fix.
datetime changing filter, _filterInput


time tests updated


test time _toInputString updated

hour with timezone offset.
test time filter updates _filterInput


timezone remove from test script


test xlsx-export date values

timezone day difference fix
test range-date setHours

test if it is working with zero hours .
prepare datetime values

test if it is working with local day.
range-date tests updated


Refactored date related tests
@programmer4web @megheaiulian
xlsx tests refactor
7b49a79
@programmer4web @megheaiulian
dom type in suites title
9ebdc15 
getDomType in helpers.js
@megheaiulian megheaiulian force-pushed the feature/NEOV-237-tests-timezone branch from f14e0ce to 9ebdc15 Compare August 14, 2018 04:19
@megheaiulian megheaiulian force-pushed the feature/NEOV-237-tests-timezone branch from f160ec4 to f8a1575 Compare August 14, 2018 05:31
@megheaiulian megheaiulian mentioned this pull request Aug 14, 2018
Merged
@nomego nomego merged commit 3a1ddae into Neovici:master Aug 14, 2018
@megheaiulian megheaiulian deleted the feature/NEOV-237-tests-timezone branch August 14, 2018 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megheaiulian megheaiulian megheaiulian approved these changes

@nomego nomego nomego approved these changes

@plequang plequang Awaiting requested review from plequang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@programmer4web @nomego @megheaiulian