Refactors and cleans up tests

Neovici · Aug 14, 2018 · f160ec4 · f160ec4
1 parent 64b9ca9
commit f160ec4
Show file tree

Hide file tree

Showing 12 changed files with 205 additions and 242 deletions.
diff --git a/test/.eslintrc.json b/test/.eslintrc.json
@@ -15,5 +15,11 @@
 		"WCT": false,
 		"getDomType": false,
 		"setupOmnitableFixture":false
+	},
+	"rules": {
+		"no-unused-vars": [
+			"warn",
+			{"varsIgnorePattern":"omnitable"}
+		]
 	}
 }
diff --git a/test/basic.html b/test/basic.html
@@ -8,14 +8,13 @@
 	<script src="../../webcomponentsjs/webcomponents-lite.js"></script>
 	<script src="../../web-component-tester/browser.js"></script>
 	<script src="../../test-fixture/test-fixture-mocha.js"></script>
-	<script src="./helpers.js"></script>
+	<script src="./helpers/utils.js"></script>
+
 	<link rel="import" href="../../test-fixture/test-fixture.html">
 	<link rel="import" href="../../iron-test-helpers/iron-test-helpers.html">
-	<link rel="import" href="helpers.html">
 	<link rel="import" href="../cosmoz-omnitable.html">
 	<link rel="import" href="../cosmoz-omnitable-columns.html">
 	<link rel="import" href="../demo/table-demo-behavior.html">
-
 </head>
 <body>
 	<test-fixture id="basic">
@@ -54,10 +53,10 @@
 
 	<script>
 	(function () {
-		/* global setupOmnitableFixture*/
 		'use strict';
-		// get dom Type from helpers.js
-		const domType = getDomType(); //eslint-disable-line no-undef
+
+		const domType = getDomType();
+
 		suite('basic' + domType, () => {
 			var omnitable,
 				data;

diff --git a/test/boolean.html b/test/boolean.html
@@ -8,11 +8,10 @@
 	<script src="../../webcomponentsjs/webcomponents-lite.js"></script>
 	<script src="../../web-component-tester/browser.js"></script>
 	<script src="../../test-fixture/test-fixture-mocha.js"></script>
-	<script src="./helpers.js"></script>
+	<script src="./helpers/utils.js"></script>
 
 	<link rel="import" href="../../test-fixture/test-fixture.html">
 	<link rel="import" href="../../iron-test-helpers/iron-test-helpers.html">
-	<link rel="import" href="helpers.html">
 	<link rel="import" href="../cosmoz-omnitable.html">
 	<link rel="import" href="../cosmoz-omnitable-columns.html">
 	<link rel="import" href="../demo/table-demo-behavior.html">
@@ -29,11 +28,9 @@
 
 	<script>
 	(function () {
-		/* global setupOmnitableFixture*/
 		'use strict';
 
-		// get dom Type from helpers.js
-		const domType = getDomType(); //eslint-disable-line no-undef
+		const domType = getDomType();
 
 		suite('basic' + domType, () => {
 			let omnitable,

diff --git a/test/fit-dropdowns.html b/test/fit-dropdowns.html
@@ -8,11 +8,10 @@
 		<script src="../../webcomponentsjs/webcomponents-lite.js"></script>
 		<script src="../../web-component-tester/browser.js"></script>
 		<script src="../../test-fixture/test-fixture-mocha.js"></script>
-		<script src="./helpers.js"></script>
+		<script src="./helpers/utils.js"></script>
 
 		<link rel="import" href="../../test-fixture/test-fixture.html">
 		<link rel="import" href="../../iron-test-helpers/iron-test-helpers.html">
-		<link rel="import" href="helpers.html">
 		<link rel="import" href="../cosmoz-omnitable.html">
 		<link rel="import" href="../cosmoz-omnitable-column-autocomplete.html">
 		<link rel="import" href="../cosmoz-omnitable-column.html">
@@ -36,15 +35,13 @@
 				</cosmoz-omnitable>
 			</template>
 		</test-fixture>
-
 		<script>
 		(function () {
-			/* global setupOmnitableFixture*/
-			// get dom Type from helpers.js
-			const domType = getDomType(); //eslint-disable-line no-undef
+			'use strict';
 
 			let omnitable;
-			const data = [
+			const domType = getDomType(),
+				data = [
 					{ id: 0, group: 'group0', name: 'Item 0' },
 					{ id: 1, group: 'group0', name: 'Item 1' },
 					{ id: 2, group: 'group1', name: 'Item 2' },

diff --git a/test/group.html b/test/group.html
@@ -8,11 +8,10 @@
 	<script src="../../webcomponentsjs/webcomponents-lite.js"></script>
 	<script src="../../web-component-tester/browser.js"></script>
 	<script src="../../test-fixture/test-fixture-mocha.js"></script>
-	<script src="./helpers.js"></script>
+	<script src="./helpers/utils.js"></script>
 
 	<link rel="import" href="../../test-fixture/test-fixture.html">
 	<link rel="import" href="../../iron-test-helpers/iron-test-helpers.html">
-	<link rel="import" href="helpers.html">
 	<link rel="import" href="../cosmoz-omnitable.html">
 	<link rel="import" href="../cosmoz-omnitable-columns.html">
 	<link rel="import" href="../demo/table-demo-behavior.html">
@@ -73,11 +72,9 @@
 
 	<script>
 	(function () {
-		/* global setupOmnitableFixture*/
 		'use strict';
 
-		// get dom Type from helpers.js
-		const domType = getDomType(); //eslint-disable-line no-undef
+		const domType = getDomType();
 
 		suite('id' + domType, () => {
 			let omnitable,
@@ -157,10 +154,10 @@
 			let omnitable,
 				data;
 
-		setup(done => {
-			data = Cosmoz.TableDemoBehavior.generateTableDemoData(10, 11, 25);
-			omnitable = setupOmnitableFixture('amount', data, () => done());
-		});
+			setup(done => {
+				data = Cosmoz.TableDemoBehavior.generateTableDemoData(10, 11, 25);
+				omnitable = setupOmnitableFixture('amount', data, () => done());
+			});
 
 			test('setting groupOn property to "amount" updates property groupOnColumn', done => {
 				omnitable.groupOn = 'amount';

diff --git a/test/hash-param.html b/test/hash-param.html
@@ -8,12 +8,10 @@
 		<script src="../../webcomponentsjs/webcomponents-lite.js"></script>
 		<script src="../../web-component-tester/browser.js"></script>
 		<script src="../../test-fixture/test-fixture-mocha.js"></script>
-		<script src="./helpers.js"></script>
+		<script src="./helpers/utils.js"></script>
 
 		<link rel="import" href="../../test-fixture/test-fixture.html">
 		<link rel="import" href="../../iron-test-helpers/iron-test-helpers.html">
-		<link rel="import" href="helpers.html">
-
 		<link rel="import" href="../cosmoz-omnitable.html">
 		<link rel="import" href="../cosmoz-omnitable-column-autocomplete.html">
 		<link rel="import" href="../cosmoz-omnitable-column.html">
@@ -40,12 +38,11 @@
 
 		<script>
 		(function () {
-			/* global setupOmnitableFixture*/
-			// get dom Type from helpers.js
-			const domType = getDomType(); //eslint-disable-line no-undef
+			'use strict';
 
 			let omnitable;
-			const data = [
+			const domType = getDomType(),
+				data = [
 					{ id: 0, group: 'group0', name: 'Item 0' },
 					{ id: 1, group: 'group0', name: 'Item 1' },
 					{ id: 2, group: 'group1', name: 'Item 2' },

diff --git a/test/helpers.js b/test/helpers.js
diff --git a/test/helpers.html → test/helpers/utils.js b/test/helpers.html → test/helpers/utils.js
@@ -1,9 +1,7 @@
-<script>
 (function () {
-	/* global window */
 	'use strict';
 
-	window.setupOmnitableFixture =  (omnitableFixtureName, data, callback) => {
+	const setupOmnitableFixture = (omnitableFixtureName, data, callback) => {
 		const omnitable = fixture(omnitableFixtureName);
 		omnitable.data = data;
 		if (omnitable.visibleColumns != null && omnitable.visibleColumns.length) {
@@ -28,7 +26,7 @@
 	};
 
 	// Detect dom type: dom=shadow vs wc-shadydom=true
-	window.getDomType = () => {
+	const getDomType = () => {
 		// match GET parameter named 'dom'
 		let param = window.location.search.match(/(\?|&)dom\=([^&]*)/), // eslint-disable-line no-useless-escape
 			dom;
@@ -38,5 +36,20 @@
 		const domType = dom && dom === 'shadow' ? ' | Using shadow DOM' : ' | Using shady DOM';
 		return domType;
 	};
+
+	const onColumnReady = (omnitable, columnIndex, done) => {
+		const checkReady = () => {
+			const {visibleColumns: visible, columns} = omnitable;
+			if (visible && visible.length > 0) {
+				omnitable.removeEventListener('visible-columns-changed', checkReady);
+				Polymer.Base.async(() => done(columns[columnIndex]), 30);
+			}
+		};
+		omnitable.addEventListener('visible-columns-changed', checkReady);
+		omnitable.notifyResize();
+		checkReady();
+	};
+
+	Object.assign(window, {setupOmnitableFixture, getDomType, onColumnReady});
 }());
-</script>
+
diff --git a/test/list.html b/test/list.html
@@ -8,11 +8,10 @@
 	<script src="../../webcomponentsjs/webcomponents-lite.js"></script>
 	<script src="../../web-component-tester/browser.js"></script>
 	<script src="../../test-fixture/test-fixture-mocha.js"></script>
-	<script src="./helpers.js"></script>
+	<script src="./helpers/utils.js"></script>
 
 	<link rel="import" href="../../test-fixture/test-fixture.html">
 	<link rel="import" href="../../iron-test-helpers/iron-test-helpers.html">
-	<link rel="import" href="helpers.html">
 	<link rel="import" href="../cosmoz-omnitable.html">
 	<link rel="import" href="../cosmoz-omnitable-columns.html">
 	<link rel="import" href="../demo/table-demo-behavior.html">
@@ -37,11 +36,10 @@
 
 	<script>
 	(function () {
-		/* global setupOmnitableFixture*/
 		'use strict';
 
 		// get dom Type from helpers.js
-		const domType = getDomType(); //eslint-disable-line no-undef
+		const domType = getDomType();
 
 		suite('basic' + domType, () => {
 			let omnitable,

diff --git a/test/range-date.html b/test/range-date.html
@@ -8,11 +8,10 @@
 	<script src="../../webcomponentsjs/webcomponents-lite.js"></script>
 	<script src="../../web-component-tester/browser.js"></script>
 	<script src="../../test-fixture/test-fixture-mocha.js"></script>
-	<script src="./helpers.js"></script>
+	<script src="./helpers/utils.js"></script>
 
 	<link rel="import" href="../../test-fixture/test-fixture.html">
 	<link rel="import" href="../../iron-test-helpers/iron-test-helpers.html">
-	<link rel="import" href="helpers.html">
 	<link rel="import" href="../cosmoz-omnitable.html">
 	<link rel="import" href="../cosmoz-omnitable-columns.html">
 	<link rel="import" href="../demo/table-demo-behavior.html">
@@ -36,43 +35,40 @@
 	</test-fixture>
 
 	<script>
-	/*global sinon chai flush setupOmnitableFixture*/
 	(function () {
 		'use strict';
 
-		// get dom Type from helpers.js
-		const domType = getDomType(); //eslint-disable-line no-undef
-
-		const data = [
-			{ age: 17,
-				amount: { amount: '12.4', currency: 'USD' },
-				date: '2023-03-21T00:00:00Z',
-				time: ''
-			},
-			{ amount: { amount: 2 },
-				date: new Date('2015-03-18T00:00:00Z')
-			},
-			{ age: -11,
-				amount: { amount: 678, currency: 'AUD' },
-				date: new Date(86400000), // Fri Jan 02 1970
-				time: 86400000
-			},
-			{ age: 9,
-				amount: { amount: -8, currency: 'EUR' },
-				date: new Date(99, 5, 24, 11, 33, 30, 0), // Thu Jun 24 1999 11:33:30 GMT+0300 (EEST)
-				time: '86400000'
-			},
-			{
-				age: 5,
-				amount: { amount: '3450', currency: 'DKK' },
-				date: new Date('2016-08-27'),
-				time: '2016-08-27T14:34:56Z'
-			},
-			{
-				date: '2017-12-22T23:00:00Z',
-				time: '00:00:00'
-			}
-		];
+		const domType = getDomType(),
+			data = [
+				{ age: 17,
+					amount: { amount: '12.4', currency: 'USD' },
+					date: '2023-03-21T00:00:00Z',
+					time: ''
+				},
+				{ amount: { amount: 2 },
+					date: new Date('2015-03-18T00:00:00Z')
+				},
+				{ age: -11,
+					amount: { amount: 678, currency: 'AUD' },
+					date: new Date(86400000), // Fri Jan 02 1970
+					time: 86400000
+				},
+				{ age: 9,
+					amount: { amount: -8, currency: 'EUR' },
+					date: new Date(99, 5, 24, 11, 33, 30, 0), // Thu Jun 24 1999 11:33:30 GMT+0300 (EEST)
+					time: '86400000'
+				},
+				{
+					age: 5,
+					amount: { amount: '3450', currency: 'DKK' },
+					date: new Date('2016-08-27'),
+					time: '2016-08-27T14:34:56Z'
+				},
+				{
+					date: '2017-12-22T23:00:00Z',
+					time: '00:00:00'
+				}
+			];
 
 		const onFilter = (column, done) => {
 			let handler;
@@ -92,19 +88,6 @@
 			});
 		};
 
-		const onColumnReady = (omnitable, columnIndex, done) => {
-			const checkReady = () => {
-				const {visibleColumns: visible, columns} = omnitable;
-				if (visible && visible.length > 0) {
-					omnitable.removeEventListener('visible-columns-changed', checkReady);
-					Polymer.Base.async(() => done(columns[columnIndex]), 30);
-				}
-			};
-			omnitable.addEventListener('visible-columns-changed', checkReady);
-			omnitable.notifyResize();
-			checkReady();
-		};
-
 		sinon.assert.expose(chai.assert, { prefix: '' });
 
 		suite('date' + domType, () => {