Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLT-0086 Item Model Update #56

Merged
merged 4 commits into from
Dec 20, 2024

Update ApiItemPayload error and schema

f914512
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

MLT-0086 Item Model Update #56

Update ApiItemPayload error and schema
f914512
Select commit
Loading
Failed to load commit list.
GitHub Actions / JUnit Test Results succeeded Dec 20, 2024 in 1s

106 passed, 0 failed and 5 skipped

Tests passed successfully

Report Passed Failed Skipped Time
target/surefire-reports/TEST-no.nb.mlt.wls.ArchitectureTest.xml 4✅ 2s
target/surefire-reports/TEST-no.nb.mlt.wls.domain.WLSServiceTest.xml 19✅ 675ms
target/surefire-reports/TEST-no.nb.mlt.wls.item.controller.ItemControllerTest.xml 6✅ 2⚪ 272ms
target/surefire-reports/TEST-no.nb.mlt.wls.item.model.ItemModelConversionTest.xml 4✅ 9ms
target/surefire-reports/TEST-no.nb.mlt.wls.item.model.ItemModelValidationTest.xml 7✅ 7ms
target/surefire-reports/TEST-no.nb.mlt.wls.order.controller.OrderControllerTest.xml 18✅ 1⚪ 688ms
target/surefire-reports/TEST-no.nb.mlt.wls.order.model.OrderModelConversionTest.xml 8✅ 8ms
target/surefire-reports/TEST-no.nb.mlt.wls.order.model.OrderModelValidationTest.xml 16✅ 11ms
target/surefire-reports/TEST-no.nb.mlt.wls.synq.controller.SynqControllerTest.xml 10✅ 2⚪ 1s
target/surefire-reports/TEST-no.nb.mlt.wls.synq.model.SynqModelConversionTest.xml 2✅ 2ms
target/surefire-reports/TEST-no.nb.mlt.wls.synq.model.SynqModelValidationTest.xml 11✅ 7ms
target/surefire-reports/TEST-no.nb.mlt.wls.TraillingSlashRedirectTest.xml 1✅ 19s

✅ target/surefire-reports/TEST-no.nb.mlt.wls.ArchitectureTest.xml

4 tests were completed in 2s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
no.nb.mlt.wls.ArchitectureTest 4✅ 2s

✅ no.nb.mlt.wls.ArchitectureTest

✅ The infrastructure packages does not access any application classes
✅ The domain model does not have any outgoing dependencies
✅ The application layer does not access any adapters
✅ A adapter should not access another adapter

✅ target/surefire-reports/TEST-no.nb.mlt.wls.domain.WLSServiceTest.xml

19 tests were completed in 675ms with 19 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
no.nb.mlt.wls.domain.WLSServiceTest 19✅ 675ms

✅ no.nb.mlt.wls.domain.WLSServiceTest

✅ addItem should not save new item but return existing item if it already exists
✅ deleteOrder should fail when order does not exist in WLS database
✅ updateOrder should fail when order does not exist
✅ getItem should return requested item when it exists in DB
✅ deleteOrder should fail when order does not exist in storage system
✅ createOrder should return existing order when trying to create one with same id and host
✅ getItem should return null if item does not exist
✅ getOrder should return null when order does not exists in DB
✅ moveItem should return when item successfully moves
✅ deleteOrder should complete when order exists
✅ moveItem throws when location is blank
✅ updateOrder should fail when items do not exist
✅ updateOrder with valid items should complete
✅ addItem should save and return new item when it does not exists
✅ moveItem should fail when item does not exist
✅ moveItem throws when count is invalid
✅ createOrder should fail if some of the items does not exist
✅ getOrder should return requested order when it exists in DB
✅ createOrder should save order in db and storage system

✅ target/surefire-reports/TEST-no.nb.mlt.wls.item.controller.ItemControllerTest.xml

8 tests were completed in 272ms with 6 passed, 0 failed and 2 skipped.

Test suite Passed Failed Skipped Time
no.nb.mlt.wls.item.controller.ItemControllerTest 6✅ 2⚪ 272ms

✅ no.nb.mlt.wls.item.controller.ItemControllerTest

✅ createItem with valid payload creates item
⚪ updateOrder with unauthorized user returns 403
✅ createItem with duplicate payload returns OK
✅ createItem handles SynQ error
⚪ updateOrder with wls user goes through
✅ createItem payload with different data but same ID returns DB entry
✅ createItem with invalid fields returns 400
✅ createItem without user returns 401

✅ target/surefire-reports/TEST-no.nb.mlt.wls.item.model.ItemModelConversionTest.xml

4 tests were completed in 9ms with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
no.nb.mlt.wls.item.model.ItemModelConversionTest 4✅ 9ms

✅ no.nb.mlt.wls.item.model.ItemModelConversionTest

✅ item converts to SynQ payload
✅ API payload converts to item
✅ item converts to API payload
✅ item converts to notification payload

✅ target/surefire-reports/TEST-no.nb.mlt.wls.item.model.ItemModelValidationTest.xml

7 tests were completed in 7ms with 7 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
no.nb.mlt.wls.item.model.ItemModelValidationTest 7✅ 7ms

✅ no.nb.mlt.wls.item.model.ItemModelValidationTest

✅ item with blank hostId should fail validation
✅ item with negative quantity should fail validation
✅ valid item should pass validation
✅ item with blank description should fail validation
✅ item with invalid callbackUrl should fail validation
✅ item with minimal valid data should pass validation
✅ item with blank location should fail validation

✅ target/surefire-reports/TEST-no.nb.mlt.wls.order.controller.OrderControllerTest.xml

19 tests were completed in 688ms with 18 passed, 0 failed and 1 skipped.

Test suite Passed Failed Skipped Time
no.nb.mlt.wls.order.controller.OrderControllerTest 18✅ 1⚪ 688ms

✅ no.nb.mlt.wls.order.controller.OrderControllerTest

✅ deleteOrder with valid data deletes order
✅ deleteOrder with blank hostOrderId returns 400
✅ createOrder with duplicate payload returns OK
✅ updateOrder with invalid fields returns 400
✅ updateOrder when order is being processed errors
✅ createOrder payload with different data but same ID returns DB entry
✅ createOrder with valid payload creates order
✅ updateOrder with valid payload updates order
✅ getOrder returns the order
✅ deleteOrder when order is in progress returns 409
✅ deleteOrder with order that does not exist returns 404
✅ deleteOrder handles synq error
⚪ getOrder for wrong client returns 403
✅ getOrder when order doesn't exist returns 404
✅ createOrder with invalid fields returns 400
✅ createOrder where SynQ says it's a duplicate but we don't have it in the DB returns Server error
✅ createOrder handles SynQ error
✅ updateOrder when order lines doesn't exists returns status 400
✅ updateOrder when order does not exists returns status 404 NOT FOUND

✅ target/surefire-reports/TEST-no.nb.mlt.wls.order.model.OrderModelConversionTest.xml

8 tests were completed in 8ms with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
no.nb.mlt.wls.order.model.OrderModelConversionTest 8✅ 8ms

✅ no.nb.mlt.wls.order.model.OrderModelConversionTest

✅ order converts to API payload
✅ API payload converts to order
✅ OrderLine converts to CreateOrderItem
✅ order converts to notification payload
✅ order converts to Mongo Order payload
✅ OrderLine converts to OrderItem
✅ OrderItem converts to OrderLine
✅ order converts to SynQ payload

✅ target/surefire-reports/TEST-no.nb.mlt.wls.order.model.OrderModelValidationTest.xml

16 tests were completed in 11ms with 16 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
no.nb.mlt.wls.order.model.OrderModelValidationTest 16✅ 11ms

✅ no.nb.mlt.wls.order.model.OrderModelValidationTest

✅ orderLine with blank hostId should fail validation
✅ update order with empty orderLine should fail validation
✅ order with empty orderLine should fail validation
✅ order with invalid orderLine should fail validation
✅ update order with blank hostOrderId should fail validation
✅ order with invalid callback URL should fail validation
✅ update order with invalid orderLine should fail validation
✅ update order with invalid address should fail validation
✅ address with blank fields should fail validation
✅ order with invalid address should fail validation
✅ valid address should pass validation
✅ valid update order should pass validation
✅ update order with invalid callback URL should fail validation
✅ valid orderLine should pass validation
✅ valid order should pass validation
✅ order with blank hostOrderId should fail validation

✅ target/surefire-reports/TEST-no.nb.mlt.wls.synq.controller.SynqControllerTest.xml

12 tests were completed in 1s with 10 passed, 0 failed and 2 skipped.

Test suite Passed Failed Skipped Time
no.nb.mlt.wls.synq.controller.SynqControllerTest 10✅ 2⚪ 1s

✅ no.nb.mlt.wls.synq.controller.SynqControllerTest

⚪ updateOrder with unauthorized user returns 403
✅ updateItem with unknown item returns 404
✅ updateItem without user returns 401
✅ updateItem with no callbackUrl still updates the item
✅ updateOrder correct payload updates order and sends callback
✅ updateOrder with empty hostOrderId returns 400
✅ updateOrder without user returns 401
✅ updateItem with invalid payload returns 400
✅ updateOrder with invalid payload returns 400
✅ updateItem correct payload updates item and sends callback
✅ updateOrder with unknown order returns 404
⚪ updateItem with unauthorized user returns 403

✅ target/surefire-reports/TEST-no.nb.mlt.wls.synq.model.SynqModelConversionTest.xml

2 tests were completed in 2ms with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
no.nb.mlt.wls.synq.model.SynqModelConversionTest 2✅ 2ms

✅ no.nb.mlt.wls.synq.model.SynqModelConversionTest

✅ SynqOrderStatus maps correctly to an OrderStatus
✅ SynqBatchMoveItemPayload maps correctly to a list of MoveItemPayloads

✅ target/surefire-reports/TEST-no.nb.mlt.wls.synq.model.SynqModelValidationTest.xml

11 tests were completed in 7ms with 11 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
no.nb.mlt.wls.synq.model.SynqModelValidationTest 11✅ 7ms

✅ no.nb.mlt.wls.synq.model.SynqModelValidationTest

✅ SynqOrderPickingConfirmationPayload with blank operator should fail validation
✅ SynqOrderStatusUpdatePayload with blank warehouse should fail validation
✅ OrderLine with blank orderTuId should fail validation
✅ SynqOrderPickingConfirmationPayload with no order line should fail validation
✅ OrderLine with invalid hostName should fail validation
✅ OrderLine with negative orderLineNumber should fail validation
✅ SynqOrderPickingConfirmationPayload with invalid order line should fail validation
✅ OrderLine with blank hostName should fail validation
✅ valid SynqOrderStatusUpdatePayload should pass validation
✅ valid SynqOrderPickingConfirmationPayload should pass validation
✅ SynqOrderPickingConfirmationPayload with blank warehouse should fail validation

✅ target/surefire-reports/TEST-no.nb.mlt.wls.TraillingSlashRedirectTest.xml

1 tests were completed in 19s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
no.nb.mlt.wls.TraillingSlashRedirectTest 1✅ 19s

✅ no.nb.mlt.wls.TraillingSlashRedirectTest

✅ path with a trailling slash redirects to proper endpoint