MLT-0086 Item Model Update #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused elvis - Remove ApiItemPayload -> ItemMetadata mapping - This should not really be required anymore
MormonJesus69420
requested changes
Dec 20, 2024
src/main/kotlin/no/nb/mlt/wls/application/hostapi/item/ApiItemPayload.kt
Outdated
Show resolved
Hide resolved
MormonJesus69420
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #55, and makes the
quantityandlocationfields within the data non-nullable. This comes with more benefits than downsides, and simplifies the API.It even removes the strange edge-case of picking an item where the location is null.
} else if (location != null) { location } else { - // Rare edge case. Log it until we can determine if this actually happens in production - logger.error { - "Item with ID '$hostId' for host '$hostName' without a location was picked. Location was set to 'UNKNOWN'." - } "UNKNOWN" }