Host API Controller changes #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the status field, which is no longer needed (MLT-0076)
MormonJesus69420
requested changes
Dec 18, 2024
src/main/kotlin/no/nb/mlt/wls/application/hostapi/item/ApiCreateItemPayload.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/no/nb/mlt/wls/application/hostapi/order/ApiCreateOrderPayload.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/no/nb/mlt/wls/application/hostapi/order/ApiCreateOrderPayload.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/no/nb/mlt/wls/application/hostapi/order/ApiCreateOrderPayload.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/no/nb/mlt/wls/application/hostapi/item/ApiCreateItemPayload.kt
Outdated
Show resolved
Hide resolved
- ACCESS_MODE removed from ApiItemPayload swagger schema - Fix wrong class mapping with ApiCreateOrderPayload - Remove status from example
MormonJesus69420
requested changes
Dec 19, 2024
src/main/kotlin/no/nb/mlt/wls/application/hostapi/item/ApiItemPayload.kt
Show resolved
Hide resolved
src/main/kotlin/no/nb/mlt/wls/application/hostapi/item/ApiItemPayload.kt
Show resolved
Hide resolved
src/main/kotlin/no/nb/mlt/wls/application/hostapi/item/ApiItemPayload.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Aaron Salwerowicz <[email protected]>
MormonJesus69420
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the unused status field from the order payload when creating orders (MLT-0076).
It does this by introducing a new payload,
ApiCreateOrderPayload, which only accepts fields we will actually process (MLT-0083). The latter is also applied for items, viaApiCreateItemPayload