Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove format=None and intersect=covers for SDSS SIAP #150

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Remove format=None and intersect=covers for SDSS SIAP #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions KNOWN_ISSUES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,12 @@ jhu_dr7_service = [s for s in services if ('SDSSDR7' in s.short_name) and ('jhu'
sdss_table = jhu_dr7_service.search(pos=coords, size=0.1, format='image/jpeg')
```

will throw an error because the service URL has a format hard-wired. If you ask for another format, it will error. Or if you specify no format whatsoever, then PyVO will add (silently) *format='all'*, which will then error.
will throw an error because the service URL has a format hard-wired. If you ask for another format, it will error.

**Workaround**:

We do not currently have a workaround for this, since our previous
workaround (specifying format='') no longer works. TBD.
We do not currently have a workaround for this, other than to omit the `format`
keyword in this search.


## pyvo.dal.ssa.SSARecord.make_dataset_filename() writes suffix 'None'
Expand Down
11 changes: 4 additions & 7 deletions content/use_case_notebooks/candidate_list_solution.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jupytext:
extension: .md
format_name: myst
format_version: 0.13
jupytext_version: 1.14.4
jupytext_version: 1.16.0
kernelspec:
display_name: Python 3 (ipykernel)
language: python
Expand All @@ -19,7 +19,7 @@ language_info:
name: python
nbconvert_exporter: python
pygments_lexer: ipython3
version: 3.9.13
version: 3.11.6
toc:
base_numbering: 1
nav_menu: {}
Expand Down Expand Up @@ -278,7 +278,6 @@ ax.scatter(ra, dec, transform=ax.get_transform('fk5'), s=500, edgecolor='red', f
Hints:
* Search the registry using `keywords=['sloan']
* Find the service with a `short_name` of `'SDSS SIAP'`
* From Known Issues, recall that an empty string must be specified to the `format` parameter dues to a bug in the service.
* After obtaining your search results, select r-band images using the `.title` attribute of the records that are returned, since `.bandpass_id` is not populated.

```{code-cell} ipython3
Expand All @@ -293,10 +292,8 @@ sdss_image_service = [s for s in sdss_image_services if 'SDSS SIAP' in s.short_n
sdss_image_service.short_name
```

As a workaround to a bug in the SDSS service, pass `format=None` when searching.

```{code-cell} ipython3
sdss_image_table = sdss_image_service.search(pos=pos, size=0.0, format=None, intersect='covers')
sdss_image_table = sdss_image_service.search(pos=pos, size=0.0)
len(sdss_image_table['Title'])
```

Expand Down Expand Up @@ -391,7 +388,7 @@ for galaxy in galaxy_subset:
# SDSS

# Find the SDSS images that overlap the position.
sdss_image_table = sdss_image_service.search(pos=pos, size=0, format=None)
sdss_image_table = sdss_image_service.search(pos=pos, size=0)

# Find the first SDSS r-band image.
sdss_rband_record = None
Expand Down
Loading