Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove format=None and intersect=covers for SDSS SIAP #150

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

stargaser
Copy link
Contributor

  • Remove the format=None from SDSS SIAP searches
  • Slightly update KNOWN_ISSUES since format=None is no longer needed
  • Remove idiosyncratic intersect='covers' from first SDSS image search

Fixes #38

Copy link
Contributor

@tomdonaldson tomdonaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. We will solve the CI elsewhere.

@tomdonaldson tomdonaldson merged commit 130c9d8 into NASA-NAVO:main Dec 14, 2023
1 of 10 checks passed
@bsipocz
Copy link
Contributor

bsipocz commented Dec 14, 2023

I suppose there was a genuine test failure with this notebook, namely something with the format

https://github.com/NASA-NAVO/navo-workshop/actions/runs/7214917787/job/19658931215#step:5:563

I'll have a look whether changing the minimal pyvo version in the oldest version run will resolve it.

@bsipocz
Copy link
Contributor

bsipocz commented Dec 14, 2023

Ahh, the format=None default has been added in v1.4.1, so I suppose we infact require that as a minimum now, or I could just update the oldest version run to agree with the check env file that Dave has already updated to 1.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Work to clean up SDSS SIAP service a bit
3 participants