Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some basic extension documentation #87

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

cohansen
Copy link
Contributor

@cohansen cohansen commented Oct 5, 2023

Just some basic docs for Extensions!

@@ -0,0 +1,64 @@
# Extensions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idle thought: Would it make sense for this to be an Advanced topic, ie Advanced - Incons?

Copy link
Contributor

@Mythicaeda Mythicaeda Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structurally, I think this page can be split into two sections:

  1. User-facing: how to find and run extensions in the UI, and that there will be a notification indicating if the run was successful (you don't need to specify that it's a Toast notif, since the average Aerie user may not be familiar with notification type names)
  2. Deployment-manager-facing: how to add new extensions, what the expected payload and response packets look like.

Those might even be two pages, one in planning and one in deployment, with planning linking to deployment in a similar way the planning mission model page links to the create a model docs.

Regardless, there ought to be a brief demo video or screenshot showing the reader what and where they should look to find extensions in the UI, as the intro paragraph just says "If there are not any extensions defined the button to view them will be hidden", with no indication to the reader of what that button looks like.

Additionally, these API queries should be at least duplicated on a page in the API section of our docs.

Comment on lines 46 to 54
After creating an Extension, you need to define the roles that are allowed to access it through the following Hasura mutation:

```graphql
mutation InsertExtensionRole($extensionRole: extension_roles_insert_input!) {
insert_extension_roles_one(object: $extensionRole) {
id
}
}
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, ignorable: Offering the bulk query may be better, if the expectation is that multiple roles can run an extension

@cohansen cohansen merged commit 5dd9739 into develop Oct 16, 2023
1 check passed
@cohansen cohansen deleted the docs/extensions branch October 16, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants