Added support for showing and accessing custom helpers #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cohansen
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
reviewed
Oct 4, 2023
AaronPlave
reviewed
Oct 4, 2023
AaronPlave
reviewed
Oct 4, 2023
AaronPlave
reviewed
Oct 4, 2023
AaronPlave
reviewed
Oct 4, 2023
AaronPlave
reviewed
Oct 4, 2023
cohansen
had a problem deploying
to
test-workflow
GitHub Actions
Failure
cohansen
had a problem deploying
to
test-workflow
GitHub Actions
Failure
duranb
reviewed
Oct 5, 2023
cohansen
had a problem deploying
to
test-workflow
GitHub Actions
Failure
cohansen
had a problem deploying
to
test-workflow
GitHub Actions
Failure
cohansen
had a problem deploying
to
test-workflow
GitHub Actions
Failure
cohansen
had a problem deploying
to
test-workflow
GitHub Actions
Failure
cohansen
had a problem deploying
to
test-workflow
GitHub Actions
Failure
cohansen
force-pushed
the
feature/custom-helper-api-calls
branch
from
aca0b1d to
051aace
Compare
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
cohansen
force-pushed
the
feature/custom-helper-api-calls
branch
from
051aace to
8eedb1c
Compare
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
cohansen
force-pushed
the
feature/custom-helper-api-calls
branch
from
8eedb1c to
8b73934
Compare
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Added support for showing and accessing custom helpers * Some misc changes for displaying extensions * Moved extension call + toast logic into effects
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Added support for showing and accessing custom helpers * Some misc changes for displaying extensions * Moved extension call + toast logic into effects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for custom helpers we're calling extensions. Here is the associated backend issue.
There's still one open question, I'm not sure how to handle the case of when no extensions are defined. Right now I'm hiding the button, but there's a case to always show it as well. I think one concern that @joswig had was that some implementations may never even use this feature, so it might be nice if it's hidden if there aren't any defined.