Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Favicon! #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added Favicon! #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CONTRIBUTORS.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Kanikaa Murarka (gh: kanikaa1234)
Aditya Chawla (gh: chawlaaditya8)
Vipin Khushu (gh: vipinkhushu)
Saurabh Badhwar (gh: h4xr)
Mayank Badola (gh: mbad0la)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should not be part of this pull request.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please update your branch with latest master changes.


* Possesses commit rights

Expand All @@ -24,3 +25,4 @@ Anup Kumar Mishra (gh: anupkumarmishra)
Ajay Kumar (gh: ajaysinghi)
Bhuvnesh Dogra (gh: bhuvneshdogra)
Pushpita Piku Dey

Binary file added favicon.ico
View file
Open in desktop
Binary file not shown.
3 changes: 3 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1">
<!-- Favicons -->
<link rel="shortcut icon" href="favicon.ico">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is favicon added?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added favicon.ico in root directory, please check.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see that in this PR. Can you please push your changes?

<link rel="apple-touch-icon" href="favicon.ico">
<!-- The above 3 meta tags *must* come first in the head; any other head content must come *after* these tags -->
<title>Mozilla Delhi | MozPacers</title>
<!-- Please add proper comments to everything that you add. It makes easier for others to read your code. -->
Expand Down