Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Favicon! #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added Favicon! #91

wants to merge 1 commit into from

Conversation

rishabh-bansal
Copy link

No description provided.

Develop (#1)
d11bed7 
* Adds @mbad0la to list of Contributors

* Added Favicon

* Added Favicon
CuriousLearner
CuriousLearner requested changes Dec 9, 2017
View reviewed changes
index.html
@@ -4,6 +4,9 @@
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1">
<!-- Favicons -->
<link rel="shortcut icon" href="favicon.ico">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is favicon added?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added favicon.ico in root directory, please check.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see that in this PR. Can you please push your changes?

manrajgrover
manrajgrover reviewed Dec 9, 2017
View reviewed changes
Copy link
Member

@manrajgrover manrajgrover left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishabh-bansal Hi, thank you for contributing. You have unintended changes which should not be part of this pull request (Because of master branch). Please create a separate branch and make changes to that before sending a pull request.

CONTRIBUTORS.txt
@@ -12,6 +12,7 @@ Kanikaa Murarka (gh: kanikaa1234)
Aditya Chawla (gh: chawlaaditya8)
Vipin Khushu (gh: vipinkhushu)
Saurabh Badhwar (gh: h4xr)
Mayank Badola (gh: mbad0la)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should not be part of this pull request.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please update your branch with latest master changes.

@CuriousLearner CuriousLearner changed the base branch from master to develop December 9, 2017 19:23
@CuriousLearner CuriousLearner changed the base branch from develop to master December 9, 2017 19:23
CuriousLearner
CuriousLearner requested changes Dec 9, 2017
View reviewed changes
index.html
@@ -4,6 +4,9 @@
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1">
<!-- Favicons -->
<link rel="shortcut icon" href="favicon.ico">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see that in this PR. Can you please push your changes?

CONTRIBUTORS.txt
@@ -12,6 +12,7 @@ Kanikaa Murarka (gh: kanikaa1234)
Aditya Chawla (gh: chawlaaditya8)
Vipin Khushu (gh: vipinkhushu)
Saurabh Badhwar (gh: h4xr)
Mayank Badola (gh: mbad0la)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please update your branch with latest master changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manrajgrover manrajgrover manrajgrover left review comments

@CuriousLearner CuriousLearner CuriousLearner requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rishabh-bansal @manrajgrover @CuriousLearner