UR Finding: Users expect to be able to save bookmarks

[avrignaud]

UR Finding: Users expect to be able to save bookmarks. Explore implementing Favorite/Bookmark support.

[fernandojsg]

I was discussing with @cvan about the idea on having bookmarks that will go directly to the content feed page. So for the MVP we won't need a specific UI for that, we could just add a new section on the content feed, and manage the interaction with them (like removing or even rename them) from the page it self instead of the FxR UI.
We will just need a button on the chrome to save these bookmarks to be shown on the CF.
I feel the same for history. As after using it intensively lately I feel these two options are hugely needed, even more when you reset the page you were navigating when quitting the browser.
So the lowest hanging fruit for this could be CF and then explore other UI options in the future that I guess will require more work both on the UI/UX and on the engineering side.

[bluemarvin]

GeckoView has an API for restoring session state on restart, we just aren't using it yet (actually, the multiprocessor switch in the developer settings is using it 🙂 )

[fernandojsg]

yeah that could be handy, but still when testing content and knowing how hard is to type on VR, sometimes I want to visit my three daily pages like redit, twitter, news and I need to type them one by one. So if we could get them from the history and show on "recently" on the content feed, or adding to bookmarks using the api that gecko should have for that but just showing them on the new tab page instead of having a proper ui for that would be handy.
Actually it's how firefox desktop is working right now right? having the recently used pages or top sites there.

[bluemarvin]

I wasn't disagreeing with you other points, I was just stating we could save state between runs if we wanted to.

[fernandojsg]

Okok I just wanted to clarify, just in case 😄

[MortimerGoro]

I like this idea a lot. I'm missing this functionality or autocompletion a lot when using the browser.

It would be nice to have something minimal for V1.

cc @bluemarvin does GV expose some function such as runJavaScript()? we could send some JSON that way

[bluemarvin]

Currently there is no way for a page to send any information back to GV. I think that is on the road map so that on-error pages and about: pages can be more interactive. I don't think there is a way to do JavaScript injection either at this time (which I think is what you are asking). But I don't think we need either for history or bookmark pages. I assume we could just generate the whole page each time and load it as data? Being able to remove/edit with out reloading the page would require a way for the page to communicated back to FxR.

[MortimerGoro]

Yes, I meant JavaScript injection.

With load it as data do you mean capture the URL content into a string, inject our JSON into a placeholder and use that instead of the live URL when calling session.loadURL()?

[bluemarvin]

I think so? Using: GeckoSession.loadData()

[MortimerGoro]

yes, that should work. My only concern could that cause any XHR/Asset loading domain errors? Which URL does loadData use for those checks?

[bluemarvin]

I don't know we would have to try it. But we could also write the page out to the cache and load locally if loadData() doesn't work.

[fernandojsg]

I've opened an issue specifically for the content feed proposal: #442 so we could leave this one as generic for the FxR chrome UI/UX

[cvan]

I had a little fun with this for an hour or so yesterday. a WIP branch with a Bookmark icon in the URL bar but still need to hook up to the bookmarks engine or reinvent a lightweight persistent data structure (get/set) keep a local storage using SQLite/whatever. (or send data to the Home frame): master...cvan:bookmarks

I responded to the ContentFeed issue #50: https://github.com/MozillaReality/ContentFeed/issues/50#issuecomment-417101452

[cvan]

and see this possible approach: #442 (comment)

[cvan]

do we have a design spec for this? I can finish my branch (based on the WIP history branch), if we decide where to place the Bookmark icon (I borrowed the SVGs that Firefox puts in the desktop URL bar) and a spot to retrieve a list of Bookmarks.

see the prior art in Firefox, Oculus Browser, Samsung Internet Browser, and even the latest Chrome for iOS.

[avrignaud]

Design is underway, but we need a meeting to discuss further. I also moved this to the Needs Design column for tracking.

[thenadj]

Attached are some ideas around bookmarking, history, tabs and downloads. This is ready for review.
UF-31 Tabs, Bookmarks, History, Downloads_007_nh.pdf

[jenniferhoang]

Ok Please see attached. I made a few visual changes and updated the UIS

Here are the Specs:
UIS-62 Bookmarks_002.pdf

Here is the User Flow Diagram:
UF-31 Tabs, Bookmarks, History, Downloads_013.pdf

Here are the assets:
UIS-62_001 Assets.zip

And other specs that have been updated in order to implement this feature...

Added the Bookmark (star) icon into the URL bar (UIS-21)
UIS-21 Window w Controls Below & Thumbnails_014.pdf

Changed the visual design of the tray and added a bookmarks icon. Please keep the same placement as before.
UIS-26 Mini Tray_007.pdf

Updated the tooltips for the tray.
UIS-40 Tooltips_003.pdf

I'll start working on the next iteration for v1.2.

[caseyyee]

Oh, one quick one: Probably swap the settings and bookmark icon positions in the tray.

Looks good otherwise!

[thenadj]

@caseyyee I agree, settings is traditionally to the right while PB and Bookmarks are related in terms of functionality (bringing up content in a new browser instance). No need to update the UI Spec. @keianhzo please note the new order of the tray icons: Help, PB, Bookmarks, Settings

[thenadj]

We are aware that @keianhzo is still working on some of the visuals in bookmarks like line spacing for titles/URL sections and hover over delete icon. In addition, here are a few more bugs that showed up for bookmarks. See attached document for details.

Bug-18 Bookmarks_001.pdf