Expose bookmarks on the Content Feed

[fernandojsg]

As exposed on #347 (comment)

TL;DR The idea is to be able to bookmark content from the FxR UI and show it on a specific category for that on the Content Feed.
Even so it could be an MVP before we have some proper UI/UX for the bookmarks on the FxR chrome, they both could coexist as they do right now on the new tab on Firefox Desktop.
The content feed should be able to remove bookmarks, although a two-ways API is encouraged for MVP we could just add them to a filter list on the localstorage for the page and just filter them from the list provided by the browser.

[bluemarvin]

I'm asking about JavaScript injection and if/when it will be added to GeckoView.

[cvan]

thanks!

see my comments elsewhere:

• UR Finding: Users expect to be able to save bookmarks #347 (comment)
• https://github.com/MozillaReality/ContentFeed/issues/50#issuecomment-417101452

it may be easier to just use Gecko's Bookmarks engine directly. or the browser.bookmarks WebExtension API.

but, yeah JavaScript could be injected or we could pass the bookmarks as the Home URL on browser load/click of the Home icon, like so:

https://webxr.today/?region=us#{"bookmarks":[{"url":"http://example.com","color":"#ccc"},{"url":"http://instagram.com","color":"#ffa500"}]}

and then the Content Feed could just listen for any hash changes, so the page wouldn't need to be refreshed:

const getHash = () => window.location.hash.substr(1);
const parseBookmarks = hash => hash ? JSON.parse(hash).bookmarks : [];

let bookmarks = parseBookmarks(getHash());

window.addEventListener('hashchange', () => {
  bookmarks = parseBookmarks(getHash());
});

[bluemarvin]

GeckoView doesn't support the Gecko Bookmarks engine, that is desktop only.

[cvan]

gotcha. which persistent data-storage API or structure would you suggest I consider using to create an MVP? master...cvan:bookmarks

[nancyhang]

@bluemarvin Is there a GV API for this?

[bluemarvin]

GV does not have a bookmark API, it is the responsibility of the embedding application to support bookmarks. The android-components project may have a bookmark component.

[keianhzo]

A bookmarks implementation is coming to Android Components. Opened a placeholder ticket for that.

[larsbergstrom]

I am assuming that we are now done with this issue, since we've chosen a different way to implement it.

[cvan]

Let's keep this open, since there is still discussion of exposing the Bookmarks in the Feed in future designs. Thanks for checking on this one.

[jvonitter]

tracking this in #759