Fixes #347: Bookmarks support

[keianhzo]

Fixes #347 #782 Bookmarks support. This requires merging also MozillaReality/vrb#54. Updated deps to Jetpack.

At the moment this only overlays the Bookmarks panel on top of the Browser window. we will need to do some more work for Surface sharing in a follow up.

[cvan]

1. very, very fantastic work! 🏅

   (for those who want to peek without diving into a headset yet)

2. all the functionality works smoothly: Bookmarking, Unbookmarking, the Bookmarks List.

3. new tray! 👍 looks slick

4. the gradient and scrolling in the Bookmarks List… I dig it.

---

a few notes, requests:

• The new Tray style is a phenomenal improvement. What stands out most to me as a, albeit super minor, visual bug: the tray's hover states for a selected item (e.g., Private Browsing).

• On the Bookmarks List page:

  • Per our messages earlier today, we can omit the L10n strings for when the list is empty. For the next L10n round, we can add them.
  • Nit: Can we reduce the line-height / margin below each Site Title and the URL? So that leaves for a larger margin between each row (regardless of whether it's highlighted/hovered or not).
    
  • Nit: When a trash can is hovered, can we still highlight the row? And show the Trash icon in its hovered state of white?
  • Nit: When a row is highlighted, perhaps the Trash icon should remain gray until the click area for the Trash button has been clicked.
    
  • Nit: Can we add a larger click area to click the Trash icons? So it'd cover the edges of the row so the user would less likely press the correct location: the row to launch the Bookmark vs. the Trash icon to delete.
    
  • Is there a way to reduce the bounce of the horizontal scrolling of the content? If I hold or scroll in particular ways, it looks like a graphical artifcating that is pretruding. Definitely a nitpick.

• Can we have about:bookmarks be its own page? Or what is the designed expected behaviour for this? Pressing the Back button I'd expect to be taken to the last page (tab/window) before I opened Bookmarks.

• Overall, with about:bookmarks, I noticed quite a few history hiccups when I'd try to use the Back/Forward buttons or Bookmark a site whilst it's still loading/idling (not sure which file this was originally reported in). Example:

  1. Press the Vuppets card in the Feed.
  2. Press the Bookmarks List button in the Tray.
  3. Press the Home icon.
  4. Notice you are not taken home.

  I notice a few other history-related scenarios. Let me know if you need further help with STRs, expected behaviours, videos, etc.

---

Again, this is phenomenal! Let me know if you have any questions or need clarification from my comments above. @avrignaud @thenadj @jenniferhoang: here's an APK I generated for this branch. If you have any comments from them or items you see in the above screenshots, feel free to comment right here in this Pull Request (or in the original issue, #347, when appropriate).

[cvan]

(ignore this if these column names are consistent with those Gecko…)

can we rename this date field timestamp to added? perhaps we'll want to later add lastVisited or lastModified, etc.

[keianhzo]

@cvan There some of outstanding issues pending fixes in master that affect this PR, so for now you can just use:

https://drive.google.com/open?id=1lMxOLU79EoTnJgBjnpRYd-3edfkhIEbi

Avoid Bookmarks resizing, there still issues pending solve that affect this and the URL bar.

If you want to build the app you'll need to:

• Ese the following VRB branch: https://github.com/keianhzo/vrb/tree/bookmarks

[cvan]

1. Press the Private Browsing icon in the Tray.
2. Press the Bookmarks icon in the Tray.
3. Notice the Tray state:

This is related to #774, etc. But figured I'd bring it up in this issue.

---

Can you swap the Bookmarks icon with the Settings icon?

[cvan]

Avoid Bookmarks resizing, there still issues pending solve that affect this and the URL bar.

gotcha, I noticed the issues. will those be fixed before landing this PR and the other PRs? or later?

[keianhzo]

@cvan I'd rather to land and fix it later as is something that's already broken in master and this way we could get bookmarks tested as much as possible in the meantime.

[cvan]

@cvan I'd rather to land and fix it later as is something that's already broken in master and this way we could get bookmarks tested as much as possible in the meantime.

that sounds good to me. after this other PRs get merged and I have a few moments, I'll file follow-up issues for cleanup.

thanks again for getting this done for 1.1. this is a super awesome feature that our users will be glad to have!

[cvan]

really great work, @keianhzo. ship it! 🚢

[MortimerGoro]

There is a resizing issue but related to: #799

[cvan]

tested the latest changes. we're good to go! 👍