Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2224 dark quote block be #11550

Merged

Conversation

kevinhowbrook
Copy link
Contributor

@kevinhowbrook kevinhowbrook commented Dec 15, 2023

Description

Based off #11547 with cherry picks from #11539

Adds a new dark single quote block

image

Link to sample test page: run inv new-env and view http://mozfest.localhost:8000/en/

Related PRs/issues: https://torchbox.monday.com/boards/1334760528/pulses/1336802224

Checklist

Tests

  • Is the code I'm adding covered by tests?

Changes in Models:

  • Did I update or add new fake data?
  • Did I squash my migration?
  • Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?

Documentation:

  • Is my code documented?
  • Did I update the READMEs or wagtail documentation?

Merge Method
💡❗Remember to use squash merge when merging non-feature branches into main

@kevinhowbrook kevinhowbrook force-pushed the feature/5171-tickets-block-BE branch 2 times, most recently from 2e50c16 to 7f3a0b0 Compare December 15, 2023 12:48
@kevinhowbrook kevinhowbrook force-pushed the feature/2224-dark-quote-block-BE branch from c4f07b5 to f2926db Compare December 15, 2023 12:57
@kevinhowbrook kevinhowbrook mentioned this pull request Dec 15, 2023
6 tasks
@kevinhowbrook kevinhowbrook marked this pull request as ready for review December 18, 2023 10:03
Base automatically changed from feature/5171-tickets-block-BE to integration/mozfest-2024 December 18, 2023 10:05
@kevinhowbrook
Copy link
Contributor Author

Needs rebasing

@kevinhowbrook kevinhowbrook force-pushed the feature/2224-dark-quote-block-BE branch 2 times, most recently from 0bb4c1b to 9fa672b Compare December 18, 2023 14:23
@kevinhowbrook kevinhowbrook force-pushed the feature/2224-dark-quote-block-BE branch from 9fa672b to 5aec3da Compare December 18, 2023 14:34
Copy link
Collaborator

@tbrlpld tbrlpld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I raised the question when looking at the frontend, but I am still not sure I understand why this is a completely detached element. It might be worth documenting the why of the decision.

Code looks fine. Just left some clarifying questions.

@kevinhowbrook kevinhowbrook force-pushed the feature/2224-dark-quote-block-BE branch from ca0eb2d to 220fd01 Compare December 19, 2023 11:40
@kevinhowbrook kevinhowbrook merged commit 6046a72 into integration/mozfest-2024 Dec 19, 2023
5 checks passed
@kevinhowbrook kevinhowbrook deleted the feature/2224-dark-quote-block-BE branch December 19, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants