Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/4691 cta block #11553

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Conversation

kevinhowbrook
Copy link
Contributor

@kevinhowbrook kevinhowbrook commented Dec 15, 2023

Description

⚠️ based on #11550 with picks from #11527 (because it's behind)

This adds a new CTA block type, it looks like this

image

image

Link to sample test page:
Related PRs/issues: https://torchbox.monday.com/boards/1334760528/pulses/1336814691

Checklist

Tests

  • Is the code I'm adding covered by tests?

Changes in Models:

  • Did I update or add new fake data?
  • Did I squash my migration?
  • Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?

Documentation:

  • Is my code documented?
  • Did I update the READMEs or wagtail documentation?

Merge Method
💡❗Remember to use squash merge when merging non-feature branches into main

@kevinhowbrook kevinhowbrook marked this pull request as ready for review December 15, 2023 15:22
@kevinhowbrook kevinhowbrook force-pushed the feature/2224-dark-quote-block-BE branch 3 times, most recently from 9fa672b to 5aec3da Compare December 18, 2023 14:34
@kevinhowbrook kevinhowbrook force-pushed the feature/4691-cta-block branch 2 times, most recently from e9c7f31 to 4844e35 Compare December 19, 2023 11:48
Base automatically changed from feature/2224-dark-quote-block-BE to integration/mozfest-2024 December 19, 2023 12:14
@kevinhowbrook kevinhowbrook merged commit 7f698d2 into integration/mozfest-2024 Dec 19, 2023
4 checks passed
@kevinhowbrook kevinhowbrook deleted the feature/4691-cta-block branch December 19, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants