Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6650 - MozFest Dark Quote #11539

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

chris-lawton
Copy link
Collaborator

Description

  • Changes the mozfest-base template to have one column
  • Adds the mozfest_dark_quote.html template
  • BE work to integrate this is to come

Desktop/Tablet/Mobile screens

Details

Screenshot 2023-12-13 at 14 03 10

Screenshot 2023-12-13 at 14 03 19

Screenshot 2023-12-13 at 14 03 51

Link to sample test page:
Related PRs/issues: #

Checklist

Tests

  • Is the code I'm adding covered by tests?

Changes in Models:

  • Did I update or add new fake data?
  • Did I squash my migration?
  • Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?

Documentation:

  • Is my code documented?
  • Did I update the READMEs or wagtail documentation?

Merge Method
💡❗Remember to use squash merge when merging non-feature branches into main

@chris-lawton chris-lawton requested a review from tbrlpld December 13, 2023 14:23
Copy link
Collaborator

@tbrlpld tbrlpld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chris-lawton Can you add some context about the reuse of existing code and new code? It looks like we are using one existing CSS class but none of the markup. I am also a bit concerned about the mix of Tailwind and component CSS classes. This feels like it will be complex to maintain. Is there anything we can do to make the two components more alike / consistent to maintain?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some context why this is building a totally new block template over reusing the existing quote block that is mentioned on the ticket? It looks like we are reusing the CSS but not the HTML. Could this be handled as a variant in mostly CSS?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've held some conversations since the ticket was created and it was decided that the dark background was enough to warrant it being a new block - i'll update the ticket to make this clearer.

The dark quote block is heavily based of the existing single_quote_block.html template (https://github.com/MozillaFoundation/foundation.mozilla.org/blob/main/network-api/networkapi/wagtailpages/templates/wagtailpages/blocks/single_quote_block.html) which also contains a mix of tailwind and css classes. Unfortunately we can't use this template directly as it extends
"./base_streamfield_block.html" which wraps everything in a container (https://github.com/MozillaFoundation/foundation.mozilla.org/blob/main/network-api/networkapi/wagtailpages/templates/wagtailpages/blocks/base_streamfield_block.html#L5) meaning we couldn't achieve the full width black background seen in the design.

The main difference between the dark quote block in the design and the existing one is the font size of the quote so i'll check in standup which one we should be following.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in standup and we're going to follow the styles of the current quote block. Updated here: ad110bc

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I feel like I talked you into less semantic HTML 😭

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I feel like I talked you into less semantic HTML 😭

@chris-lawton chris-lawton force-pushed the feature/6650-dark-quote branch from 33344ec to b1352cb Compare December 15, 2023 11:56
@chris-lawton chris-lawton merged commit 0a1742c into integration/mozfest-2024 Dec 15, 2023
4 checks passed
@chris-lawton chris-lawton deleted the feature/6650-dark-quote branch December 15, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants