Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade sqlx package version #57

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

f3r10
Copy link
Contributor

@f3r10 f3r10 commented Jul 14, 2024

Upgrade sqlx dependency #32

@grunch grunch merged commit c25b630 into MostroP2P:main Jul 17, 2024
1 check passed
@grunch
Copy link
Member

grunch commented Jul 17, 2024

Thanks for your contribution @f3r10

@grunch
Copy link
Member

grunch commented Jul 17, 2024

I have news about this, after I try to publish a new version with this change on crates.io I get this response:

cargo publish
    Updating crates.io index
error: all dependencies must have a version specified when publishing.
dependency `sqlx-crud` does not specify a version
Note: The published dependency will use the version from crates.io,
the `git` specification will be removed from the dependency declaration.

We need to push the new fork as a new project on crates.io right?

@grunch
Copy link
Member

grunch commented Jul 19, 2024

I have news about this, after I try to publish a new version with this change on crates.io I get this response:

cargo publish
    Updating crates.io index
error: all dependencies must have a version specified when publishing.
dependency `sqlx-crud` does not specify a version
Note: The published dependency will use the version from crates.io,
the `git` specification will be removed from the dependency declaration.

We need to push the new fork as a new project on crates.io right?

@f3r10 let me know what do you think about this

@f3r10
Copy link
Contributor Author

f3r10 commented Jul 19, 2024

Sorry for the late response,
Yes, you are right @grunch it looks like it is necessary to push the fork to crates.io so that it will be possible to define a version on the Cargo.toml file

@f3r10
Copy link
Contributor Author

f3r10 commented Jul 19, 2024

maybe this option could be better than publishing the fork project to creates.io: https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#working-with-an-unpublished-minor-version
Let me know what could be the best option

@f3r10
Copy link
Contributor Author

f3r10 commented Jul 19, 2024

[dependencies]
sqlx-crud = { version = "0.4.0", features = [
  "runtime-tokio-rustls",
], optional = true }
...

[patch.crates-io]
sqlx-crud = { git = "https://github.com/f3r10/sqlx-crud" }

With this change, it looks like it works

@grunch
Copy link
Member

grunch commented Jul 21, 2024

[dependencies]
sqlx-crud = { version = "0.4.0", features = [
  "runtime-tokio-rustls",
], optional = true }
...

[patch.crates-io]
sqlx-crud = { git = "https://github.com/f3r10/sqlx-crud" }

With this change, it looks like it works

got this done and published on version 0.6.2

@grunch grunch mentioned this pull request Jul 21, 2024
@f3r10
Copy link
Contributor Author

f3r10 commented Jul 22, 2024

I am going to create a PR to Mostro updating the dependencies with the new version mostro-core an the patch of sqlx

@grunch
Copy link
Member

grunch commented Aug 7, 2024

unfortunately I have to revert this PR because it is not working properly with MostroP2P/mostro#334

I will do this PR again but it's not going to be merged until we are sure the mostrod PR can work properly with it

@grunch
Copy link
Member

grunch commented Aug 7, 2024

@f3r10

@f3r10
Copy link
Contributor Author

f3r10 commented Aug 7, 2024

sure, I understand. I am going to check MostroP2P/mostro#334 to see what is missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants