Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sqlx dependency #166

Open
grunch opened this issue Dec 18, 2023 · 10 comments
Open

Upgrade sqlx dependency #166

grunch opened this issue Dec 18, 2023 · 10 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@grunch
Copy link
Member

grunch commented Dec 18, 2023

Upgrade sqlx to latest version

@grunch grunch added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 18, 2023
@f3r10
Copy link

f3r10 commented Jul 8, 2024

hi @grunch as a PR I am trying to update the sqlx version but it depends that sqlx-crud also updates to the latest version of sqlx 😅

.. btw I cloned sqlx-crud and after updating the sqlx version and some tweaks on mostro and mostro-core, I was able to update to the latest version of sqlx.

@grunch
Copy link
Member Author

grunch commented Jul 8, 2024

wow that's great, I remember that we broke some things after try to update, I don't remember exactly but @arkanoider was working on it, maybe he remember and can send some thoughs about it :D

@arkanoider
Copy link
Collaborator

@f3r10 you are a hero doing this.
If I can help you ask freely...
I think sqlx crud just needs to be updated to latest.sqlx, but rhen we have to work on it and dev never answered!
Your commitment is super good!

@f3r10
Copy link

f3r10 commented Jul 8, 2024

maybe until the maintainer of sqlx-crud bumps the version of sqlx, it would be possible to create a fork of the project and update the reference of the dependency like so

sqlx-crud = { git = "https://github.com/f3r10/sqlx-crud", features = ["runtime-tokio-rustls"] }

@arkanoider
Copy link
Collaborator

Yep! I think he dropped it, we should takeover! Great to have a volunteer...

@f3r10
Copy link

f3r10 commented Jul 14, 2024

I think the first step for upgrading sqlx version would be in mostro-core, so I created a pull request about: MostroP2P/mostro-core#57

@arkanoider
Copy link
Collaborator

I think the first step for upgrading sqlx version would be in mostro-core, so I created a pull request about: MostroP2P/mostro-core#57

This is the starting point for sure, it's passed some time. Now I think if I remember well that also mostro needs to update sqlx otherwise we will have some errors. Test it please...you need to bump update on Mostro and see if it compiles correctly and work.
Before merging this we have to be sure to do not break all, then to maintain it i had started to study the crate, which is a nice derivative macro! Hope you want to try to learn it...one nice thing should be having also blocking calls to CRUD functions for example...

@f3r10
Copy link

f3r10 commented Jul 19, 2024

yes, you are right it would also be necessary to bump the version of sqlx and sqlx-crud on Mostro. I have already tested it and Mostro runs correctly.

I have not worked with macros on Rust, but it would be nice to learn it.

@grunch
Copy link
Member Author

grunch commented Sep 18, 2024

This issue is free to be taken now

@juanramonperez
Copy link

Assigning this to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants