Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom comfyui venv #117

Merged
merged 8 commits into from
Aug 11, 2023
Merged

custom comfyui venv #117

merged 8 commits into from
Aug 11, 2023

Conversation

ljleb
Copy link
Contributor

@ljleb ljleb commented Aug 10, 2023

Use the venv of the comfyui install specified in the settings if there is one.

@ljleb
Copy link
Contributor Author

ljleb commented Aug 11, 2023

Should we add a setting to pick the venv or just automatically detect the venv? I think we should use the comfyui venv if there is one.

@ljleb
Copy link
Contributor Author

ljleb commented Aug 11, 2023

Maybe add a setting later if there are requests for it.

@ljleb ljleb marked this pull request as ready for review August 11, 2023 13:39
@ljleb ljleb requested a review from PladsElsker August 11, 2023 13:39
@ljleb ljleb merged commit a0d3cee into main Aug 11, 2023
@ljleb ljleb deleted the custom-venv branch August 11, 2023 20:31
@PladsElsker
Copy link
Contributor

I think there should ultimately be a dropdown to chose the method.

  • Default (what it is right now)
  • Seperated venvs
  • Shared venvs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants