Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfyUI-Extension installation outdated #227

Open
schoenid opened this issue Aug 21, 2024 · 4 comments
Open

ConfyUI-Extension installation outdated #227

schoenid opened this issue Aug 21, 2024 · 4 comments

Comments

@schoenid
Copy link

Trying to install some of the newer nodes causes venv to be destroyed.

See also WASasquatch/was-node-suite-comfyui#457 (comment)

I had a coomment there:

Ah you are using the extension. That is a pretty old extension which hasn't had an update in 7mo.

@schoenid schoenid changed the title ConfyUI installation outdated ConfyUI-Extension installation outdated Aug 21, 2024
@PladsElsker
Copy link
Contributor

It is old and pretty much no longer maintained.
That being said, there is an option in the settings to select separated venvs for A1111 and ComfyUI to work together nicely.

@PladsElsker
Copy link
Contributor

#117

@PladsElsker
Copy link
Contributor

Ah, maybe there isn't one? I don't remember

@PladsElsker
Copy link
Contributor

PladsElsker commented Aug 24, 2024

def get_comfyui_executable(comfyui_install_location: Path) -> str:
executable = sys.executable
if os.name == 'nt':
executable_paths = [
comfyui_install_location / 'venv' / 'scripts' / 'python.exe',
comfyui_install_location.parent / 'python_embeded' / 'python.exe',
]
else:
executable_paths = [
comfyui_install_location / 'venv' / 'bin' / 'python',
comfyui_install_location.parent / 'python_embeded' / 'python',
]
for potential_executable in executable_paths:
if potential_executable.exists():
executable = potential_executable
print('[sd-webui-comfyui]', 'Detected custom ComfyUI venv:', executable)
break
return str(executable)

If you install ComfyUI separately with its own venv, and reference the install location in the settings, it should work, assuming the extension still works at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants