Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tidy checks #857

Merged
merged 3 commits into from
Dec 10, 2023
Merged

Conversation

Sustrak
Copy link
Contributor

@Sustrak Sustrak commented Dec 10, 2023

Two new checks for slang-tidy:

NoDotStarInPortConnection: Checks if the syntax .* has been used to
connect ports

NoImplicitPortNameInPortConnection: Checks if the syntax .port_name has
been used to connect ports

Sustrak and others added 3 commits December 10, 2023 12:56
This commit adds two new checks for port connections:

NoDotStarInPortConnection: Checks if the syntax .* has been used to
connect ports

NoImplicitPortNameInPortConnection: Checks if the syntax .port_name has
been used to connect ports
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Merging #857 (f3f1fc5) into master (536a09c) will increase coverage by 0.00%.
Report is 9 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #857    +/-   ##
========================================
  Coverage   93.71%   93.72%            
========================================
  Files         191      191            
  Lines       46552    46673   +121     
========================================
+ Hits        43626    43743   +117     
- Misses       2926     2930     +4     

see 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 536a09c...f3f1fc5. Read the comment docs.

@MikePopoloski MikePopoloski merged commit 74f8fcc into MikePopoloski:master Dec 10, 2023
18 checks passed
@Sustrak Sustrak deleted the feature/new-tidy-checks branch December 10, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants