Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong name returned for tidy checker. #854

Closed
Krym4s opened this issue Dec 6, 2023 · 2 comments
Closed

Wrong name returned for tidy checker. #854

Krym4s opened this issue Dec 6, 2023 · 2 comments
Labels
slang-tidy

Comments

@Krym4s
Copy link
Contributor

Krym4s commented Dec 6, 2023

This tidy checker returns name of another checker ("AlwaysCombNonBlocking"), this should return "AlwaysFFBlocking", isn't it?

https://github.com/MikePopoloski/slang/blob/52ee547b665fe7b8974a8f7e66de7c37beef4aae/tools/tidy/src/style/AlwaysFFBlocking.cpp#L64C63-L64C63
@MikePopoloski
Copy link
Owner

Yes, looks like a typo.

Sustrak added a commit to Sustrak/slang that referenced this issue Dec 10, 2023
@Sustrak
[slang-tidy] Minor syntax fixes in the code
cccec00 
Solves MikePopoloski#854
@Sustrak
Copy link
Contributor

Sustrak commented Dec 10, 2023

#857 should fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
slang-tidy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MikePopoloski @Sustrak @Krym4s