-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Rails.application.credentials instead of deprecated secrets #23254
Use Rails.application.credentials instead of deprecated secrets #23254
Conversation
Fixes: DEPRECATION WARNING: `Rails.application.secrets` is deprecated in favor of `Rails.application.credentials` and will be removed in Rails 7.2.
@jrafanie I assume we'll have to do this in all of the providers as well? |
Yea, I see that |
Thanks, I did see a warning from one of the plugins in core, it might have been the hmc provider. Yes, I expect we'll have to do this throughout the plugins. At this point, I'm trying to get core to work and then I'll move to the plugins.
Thanks, I'll add it to the the main issue. |
It's all over the place in the providers. Additionally, I think it's in the generator as well |
I added it to #23200 |
Partial Revert of ManageIQ#23254 Enhanced the test to check both the app config secret_key_base and app secret_key_base as there's caches in both. These test changes make the test fail if we do not clear the cached secrets on Rails 7.0.
Partial Revert of ManageIQ#23254 Enhanced the test to check both the app config secret_key_base and app secret_key_base as there's caches in both. These test changes make the test fail if we do not clear the cached secrets on Rails 7.0.
We're switching to rails credentials to keep current with rails 7.1 and the future. Note, we're assuming we won't want to commit and share encrypted credentials. If we want to share them, such as for recording cassettes, the comments describe how to switch to only ignoring the plain text encryption key files. Followup to: ManageIQ#23254 Required for: ManageIQ/manageiq-providers-autosde#253
We're switching to rails credentials to keep current with rails 7.1 and the future. Note, we're assuming we won't want to commit and share encrypted credentials. If we want to share them, such as for recording cassettes, the comments describe how to switch to only ignoring the plain text encryption key files. Followup to: ManageIQ#23254 Required for: ManageIQ/manageiq-providers-autosde#253
Fixes:
DEPRECATION WARNING:
Rails.application.secrets
is deprecated in favor ofRails.application.credentials
and will be removed in Rails 7.2.Extracted from #23225