Reset cached secrets on Rails 7.0 #23259
Merged
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
approved these changes
Nov 6, 2024
Partial Revert of ManageIQ#23254 Enhanced the test to check both the app config secret_key_base and app secret_key_base as there's caches in both. These test changes make the test fail if we do not clear the cached secrets on Rails 7.0.
jrafanie
force-pushed
the
properly-reset-cached-secrets
branch
from
70ad46d to
8f8ac7e
Compare
|
Fixed a minor typo |
bdunne
approved these changes
Nov 6, 2024
bdunne
added a commit
that referenced
this pull request
Nov 7, 2024
Reset cached secrets on Rails 7.0 (cherry picked from commit bd4b369)
|
Backported to radjabov in ef52dff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial Revert of #23254
Enhanced the test to check both the app config secret_key_base and app secret_key_base as there's caches in both. These test changes make the test fail if we do not clear the cached secrets on Rails 7.0.
This seems to fix an issue with caching in both secrets and the config on rails 7.0: