Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list all vmdb directories in the gem #352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

list all vmdb directories in the gem #352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions rpm_spec/subpackages/manageiq-core
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,38 @@ done

%files core
%defattr(-,root,root,-)
%{app_root}
%{app_root}/AUTHORS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to add a %dir %{app_root} for the directory itself?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so %dir says to add a directory only and not the files underneath it.

I was pretty sure that adding the file app_root/AUTHORS (in addition to the next 10
lines) would add app_root with the default attributes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on what I'm reading we probably need %dir for app_root, since we want the rpm to own that dir.

%{app_root}/CHANGELOG.md
%{app_root}/CONTRIBUTING.md
%{app_root}/Dockerfile
%{app_root}/Gemfile
%{app_root}/LICENSE.txt
%{app_root}/NOTICE.txt
%{app_root}/Procfile.example
%{app_root}/README.md
%{app_root}/Rakefile
%{app_root}/VERSION
%{app_root}/app
%{app_root}/bin
%{app_root}/bundler.d
%attr(-,manageiq,manageiq) %{app_root}/certs
%attr(-,manageiq,manageiq) %{app_root}/config
%{app_root}/config.ru
%{app_root}/container-assets
%{app_root}/content
%attr(-,manageiq,manageiq) %{app_root}/data
%{app_root}/db
%{app_root}/lib
%{app_root}/locale
%attr(-,manageiq,manageiq) %{app_root}/log
%{app_root}/product
%{app_root}/public
%{app_root}/script
%{app_root}/spec
%{app_root}/systemd
%attr(-,manageiq,manageiq) %{app_root}/tmp
%attr(-,manageiq,manageiq) %{app_root}/data
%{app_root}/tools

%config(noreplace) %{app_root}/config/cable.yml
%exclude %{app_root}/public/pictures
%exclude %{app_root}/public/assets
Expand Down