list all vmdb directories in the gem #352

kbrock · 2022-12-13T18:27:04Z

Overview

Fixes #332

The goal is to remove a warning:

warning: File listed twice: /var/www/miq/vmdb/certs
(a few hundred files do this)

Before

%defattr(-,root,root,-)
%{app_root}
%attr(-,manageiq,manageiq) %{app_root}/certs

We stated that we included all files recursively under app_root (/var/www/miq/vmdb).
Then we stated a few directories (with different privileges) under app_root.
So we ended up with duplicates.

Why?

Most app_root subdirectories are owned by root, which is the default, so using the app_root line works.

There are a few config directories that need to be editable and owned by the end user. That is why they are listed with the %attr() syntax.

After

We explicitly listed each folder in the rails root.

I would have liked to keep on using the app_root rule so any additional files would be auto added.

This is tricky because we tend to not debug the directory listing of the rpm So there is a good chance that we will add a directory to app_root (vmdb / manageiq-core root) and will think it is all set but will fail on the appliance.

Overview ======== Fixes ManageIQ#332 The goal is to remove a warning: ``` warning: File listed twice: /var/www/miq/vmdb/certs (a few hundred files do this) ``` Before ====== ``` %defattr(-,root,root,-) %{app_root} %attr(-,manageiq,manageiq) %{app_root}/certs ``` We stated that we included all files recursively under app_root (/var/www/miq/vmdb). Then we stated a few directories (with different privileges) under app_root. So we ended up with duplicates. Why? ==== Most app_root subdirectories are owned by root, which is the default, so using the app_root line works. There are a few config directories that need to be editable and owned by the end user. That is why they are listed with the `%attr()` syntax. After ===== We explicitly listed each folder in the rails root. I would have liked to keep on using the app_root rule so any additional files would be auto added. This is tricky because we tend to not debug the directory listing of the `rpm` So there is a good chance that we will add a directory to app_root (vmdb / manageiq-core root) and will think it is all set but will fail on the appliance.

bdunne · 2022-12-13T19:30:45Z

rpm_spec/subpackages/manageiq-core

@@ -55,12 +55,38 @@ done

 %files core
 %defattr(-,root,root,-)
-%{app_root}
+%{app_root}/AUTHORS


Do we also need to add a %dir %{app_root} for the directory itself?

so %dir says to add a directory only and not the files underneath it.

I was pretty sure that adding the file app_root/AUTHORS (in addition to the next 10
lines) would add app_root with the default attributes.

Based on what I'm reading we probably need %dir for app_root, since we want the rpm to own that dir.

Fryguy · 2022-12-15T16:55:25Z

I'm concerned keeping this up to date will be a pain - I wonder if we can leverage %exclude to make it work? Something like the following?

%files core
%defattr(-,root,root,-)
%{app_root}
%exclude %{app_root}/certs
%attr(-,manageiq,manageiq) %{app_root}/certs
%exclude %{app_root}/config
%attr(-,manageiq,manageiq) %{app_root}/config
%exclude %{app_root}/log
%attr(-,manageiq,manageiq) %{app_root}/log
%exclude %{app_root}/tmp
%attr(-,manageiq,manageiq) %{app_root}/tmp
%exclude %{app_root}/data
%attr(-,manageiq,manageiq) %{app_root}/data
%config(noreplace) %{app_root}/config/cable.yml
%exclude %{app_root}/public/pictures
%exclude %{app_root}/public/assets
...

kbrock · 2022-12-19T19:54:25Z

a. I'm very concerned about keeping this up to date
b. the exclude rule is the first one I tried

I'll try one more time with the %exclude operations.
The rpms were missing the directories last time I tries
The last I'm pretty sure it did not include any of those directories

Alternatives

Our big issue is that we are trying to put down a directory with both code and user data there.

Put the user files elsewhere (e.g.: copy daemons like httpd and put config in /etc/httpd)
Just set everything owned by manageiq user (code and config files) and be done with it
Put the user files into a separate rpm (where everything is miq owned)

kbrock · 2022-12-20T21:08:22Z

yea, just tried the exclude example again. it is so clean but it does not work

%defattr(-,root,root,-)
%{app_root}
%exclude %{app_root}/certs
%exclude %{app_root}/config
%exclude %{app_root}/data
%exclude %{app_root}/log
%exclude %{app_root}/tmp
%attr(-,manageiq,manageiq) %{app_root}/certs
%attr(-,manageiq,manageiq) %{app_root}/config
%attr(-,manageiq,manageiq) %{app_root}/data
%attr(-,manageiq,manageiq) %{app_root}/log
%attr(-,manageiq,manageiq) %{app_root}/tmp
%config(noreplace) %{app_root}/config/cable.yml
%exclude %{app_root}/public/pictures
%exclude %{app_root}/public/assets

miq-bot · 2023-03-27T00:01:05Z

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

miq-bot · 2023-07-03T00:00:33Z

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

kbrock · 2023-07-27T17:50:07Z

think our current suggestion is to extract user content into its own gem and have all of those files owned by manageiq user

miq-bot · 2023-07-27T17:55:24Z

Checked commit kbrock@80b19f9 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 👍

miq-bot · 2023-10-30T00:00:12Z

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

miq-bot · 2024-02-05T00:00:27Z

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

miq-bot · 2024-05-06T00:00:05Z

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

miq-bot · 2024-08-12T00:00:20Z

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

miq-bot · 2024-11-25T00:00:53Z

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

kbrock added the bug Something isn't working label Dec 13, 2022

kbrock assigned Fryguy and bdunne Dec 13, 2022

bdunne reviewed Dec 13, 2022

View reviewed changes

miq-bot added the stale label Mar 27, 2023

miq-bot closed this Jul 3, 2023

kbrock reopened this Jul 27, 2023

kbrock removed the stale label Jul 27, 2023

miq-bot added the stale label Oct 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

list all vmdb directories in the gem #352

list all vmdb directories in the gem #352

kbrock commented Dec 13, 2022

bdunne Dec 13, 2022

kbrock Dec 14, 2022

Fryguy Dec 15, 2022

Fryguy commented Dec 15, 2022 •

edited

Loading

kbrock commented Dec 19, 2022 •

edited

Loading

kbrock commented Dec 20, 2022

miq-bot commented Mar 27, 2023

miq-bot commented Jul 3, 2023

kbrock commented Jul 27, 2023

miq-bot commented Jul 27, 2023

miq-bot commented Oct 30, 2023

miq-bot commented Feb 5, 2024

miq-bot commented May 6, 2024

miq-bot commented Aug 12, 2024

miq-bot commented Nov 25, 2024

list all vmdb directories in the gem #352

Are you sure you want to change the base?

list all vmdb directories in the gem #352

Conversation

kbrock commented Dec 13, 2022

Overview

Before

Why?

After

bdunne Dec 13, 2022

Choose a reason for hiding this comment

kbrock Dec 14, 2022

Choose a reason for hiding this comment

Fryguy Dec 15, 2022

Choose a reason for hiding this comment

Fryguy commented Dec 15, 2022 • edited Loading

kbrock commented Dec 19, 2022 • edited Loading

Alternatives

kbrock commented Dec 20, 2022

miq-bot commented Mar 27, 2023

miq-bot commented Jul 3, 2023

kbrock commented Jul 27, 2023

miq-bot commented Jul 27, 2023

miq-bot commented Oct 30, 2023

miq-bot commented Feb 5, 2024

miq-bot commented May 6, 2024

miq-bot commented Aug 12, 2024

miq-bot commented Nov 25, 2024

Fryguy commented Dec 15, 2022 •

edited

Loading

kbrock commented Dec 19, 2022 •

edited

Loading