Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial support for MUME's room id #308

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Initial support for MUME's room id #308

wants to merge 16 commits into from

Commits on Mar 16, 2024

  1. improve INVALID_ROOMID initialization: replace UINT_MAX -> uint32_t(-… 

    …1), in theory they can be different
    @cosmos72 @nschimme
    cosmos72 authored and nschimme committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    f2aceb6 View commit details
    Browse the repository at this point in the history

  2. replace UINT_MAX -> uint32_t(-1) also in src/mapstorage/mapstorage.cpp, 

    use INVALID_ROOMID in more places
    @cosmos72 @nschimme
    cosmos72 authored and nschimme committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    7ac81e6 View commit details
    Browse the repository at this point in the history

  3. add class ServerRoomId, and ServerRoomId field to class Room. 

    Update XmlMapStorage to load/save ServerRoomId in MM2XML maps.
    @cosmos72 @nschimme
    cosmos72 authored and nschimme committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    9e7f49e View commit details
    Browse the repository at this point in the history

  4. rename class ServerRoomId -> RoomServerId because it's a datum inside… 

    … each Room
    @cosmos72 @nschimme
    cosmos72 authored and nschimme committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    2d2825b View commit details
    Browse the repository at this point in the history

  5. remove annotation "// clang-format off" from src/expandoracommon/room… 

    ….h and src/mapstorage/XmlMapStorage.cpp
    @cosmos72 @nschimme
    cosmos72 authored and nschimme committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    6ea7883 View commit details
    Browse the repository at this point in the history

  6. add missing forward declaration to src/global/roomserverid.h

    @cosmos72 @nschimme
    cosmos72 authored and nschimme committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    e2e0a3e View commit details
    Browse the repository at this point in the history

  7. parse received XML room id

    @cosmos72 @nschimme
    cosmos72 authored and nschimme committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    e773e32 View commit details
    Browse the repository at this point in the history

  8. slightly optimize src/pathmachine/pathmachine.cpp

    @cosmos72 @nschimme
    cosmos72 authored and nschimme committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    703e465 View commit details
    Browse the repository at this point in the history

  9. clang-format src/expandoracommon/room.h

    @cosmos72 @nschimme
    cosmos72 authored and nschimme committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    2b0ef7a View commit details
    Browse the repository at this point in the history

  10. clang-format src/mapstorage/XmlMapStorage.cpp

    @cosmos72 @nschimme
    cosmos72 authored and nschimme committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    ac47327 View commit details
    Browse the repository at this point in the history

  11. replace 'and' -> && in src/parser/mumexmlparser.cpp

    @cosmos72 @nschimme
    cosmos72 authored and nschimme committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    281892c View commit details
    Browse the repository at this point in the history

  12. start adding support for RoomServerId to path machine

    @cosmos72 @nschimme
    cosmos72 authored and nschimme committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    3096bac View commit details
    Browse the repository at this point in the history

  13. fix formatting of src/expandoracommon/room.h and src/mapdata/ExitFiel… 

    …dVariant.h
    @cosmos72 @nschimme
    cosmos72 authored and nschimme committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    9b273b6 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. refresh graphics when changing settings

    @nschimme
    nschimme committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    61667dc View commit details
    Browse the repository at this point in the history

  2. support mapid in room edit dialog

    @nschimme
    nschimme committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    23491db View commit details
    Browse the repository at this point in the history

  3. tweak mapid logic

    @nschimme
    nschimme committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    b61ce75 View commit details
    Browse the repository at this point in the history