-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for MUME's room id #308
base: master
Are you sure you want to change the base?
Conversation
I've been following this merge request, but there's been no activity. What are the next steps here @nschimme ? I feel support for MUME's room ids is the most important feature in the potential pipeline for MMapper right now... |
I'll try to answer while waiting for @nschimme take on this: The next step is extending path machine algorithms to add MUME room ids as a very high priority/confidence source of location info. |
Thanks for your reply @cosmos72. I'd say that it would be good to get in the parsing and saving of the current room id to the map (where the current location is known with a high degree of certainty using the existing algorithm), and ignore everything else GMCP-related (as that may - or should - yet change), and including the path machine stuff. This way, people can start to get their maps updated (as the default map having this is sort of a blocker on #306 ). |
Hi @Sebster7, Although, it turned out that this means reconciling room ids with the other mechanisms used by path machine for recognizing and identifying rooms. So you still have to modify the path machine, although the changes are probably simpler: after all, the intention is to only WRITE room ids into room, not to READ them back and use them as an additional source of truth inside path machine algorithm. |
…1), in theory they can be different
use INVALID_ROOMID in more places
Update XmlMapStorage to load/save ServerRoomId in MM2XML maps.
….h and src/mapstorage/XmlMapStorage.cpp
7bdf82a
to
b61ce75
Compare
Parses MUME's room id into a newly created class RoomServerId,
and also adds a RoomServerId field to relevant classes: Room and ParseEvent.
Definitely NOT complete, but it's a first step.
The path machine code definitely needs review from someone who knows it better than me.