Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for excessive post highlighting when slow-scrolling #278

Closed
wants to merge 1 commit into from

Conversation

Xen4n
Copy link

@Xen4n Xen4n commented Oct 6, 2023

Problem

When user is slow-scrolling (keeps finger unmoved during some milliseconds), there are ripple highlight starts (when there is no tap, just scroll). All logic based inside the AppKit and leaves no possibilities for external control.

Fix

I created MoshidonUsableRecyclerView with overriden default selector by putting it in SelectorWrapper that provides additional delay before highlight starts.
Also I switch on MoshidonUsableRecyclerView usage instead of base UsableRecyclerView with each @id/list.
Also so good this class does not interfere with GestureDetector, setting custom selector (including null) or onTouchEvent dispatching.

(You can change RecyclerView name if you want)

@LucasGGamerM
Copy link
Owner

I don't think this is that bug of an issue to warrant this many changes. I would rather stick to the default behavior as much as possible in this case

@Xen4n
Copy link
Author

Xen4n commented Oct 7, 2023

Problem keeps inside of UsableRecyclerView behavior, it starts highlighting on every touchdown, not on tap nor long-tap detected. Better solution is fix UsableRecycleView in AppKit if it possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants